feat(ads-client): add telemetry support #7111
Open
+540
−249
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Telemetry Architecture
Core Telemetry Trait
A generic
Telemetry<A>trait at the core/std layer:record(&self, event: &A)methodSuper Traits for Complex Components
Higher-level traits compose multiple telemetry types:
MARSTelemetry: RequiresTelemetry<CacheOutcome>+Telemetry<serde_json::Error>AdsTelemetry: ComposesMARSTelemetry+ specific error types (RequestAdsError,RecordClickError, etc.) +ClientOperationEventThis provides granular control without coupling modules to specific implementations.
FFI Layer: Platform-Specific Implementations
The
MozAdsTelemetrytrait is exposed via UniFFI for iOS/Android:MozAdsClientConfigMozAdsTelemetryWrapperbridges FFI trait to core telemetry traitsBenefits
This keeps the core clean and flexible while enabling platform-specific telemetry integration.
Pull Request checklist
[ci full]to the PR title.