Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source Code Package Compatibility #68

Closed
wants to merge 82 commits into from
Closed

Source Code Package Compatibility #68

wants to merge 82 commits into from

Conversation

chrstinalin
Copy link
Contributor

@chrstinalin chrstinalin commented Jul 3, 2024 •
edited
Loading

Closes #59, closes #67.

Changes

  • Makes all xpi functionality compatible with source code packages, including: leaving annotations, exporting comments, and diffing.
  • Splits the addons root folder into two more directories: xpi and source.
  • Split the sidebar into two different sections representing each directory.
  • When the user reviews a new addon that has a source code package attributed to it, Assay will prompt the user and ask whether they want to install the XPI or the source.
image

Note: The Codecov isn't entirely accurate as I added more tests in parent branches.

chrstinalin and others added 30 commits June 5, 2024 10:08
@chrstinalin
readonly
a7caa5d
@chrstinalin
readonly functionality
0e62891
@chrstinalin
extension and types files readonly
64d0162
@chrstinalin
linter
a40f243
@chrstinalin
removed unneeded file
2cc9a7b
@chrstinalin
better comments
05247ca
@chrstinalin
testing
b2e8bd1
@chrstinalin
testing reviewRootDir
730b0f2
@chrstinalin
guid typo
fa3c3e0
@chrstinalin
guid fix without work from separate branch
61bae65
@chrstinalin
Merge branch 'main' into readonly-linter
e8ffec2
@chrstinalin
fixed merge
02e10b6
@chrstinalin
reviewer url compatibility
e299da5
@chrstinalin
test friendly delimiter const
87c7e76
@chrstinalin
allow addon slug errors to properly appear rather than silently throw…
b2b762e 
…ing in console
@chrstinalin
enum
895a8c8
@chrstinalin
scaffolding
faca00f
@chrstinalin
refactoring
17ab860
@chrstinalin
controllers
0e5bd1c
@chrstinalin
controller
555279a
@chrstinalin
connections
2cbf2fd
@chrstinalin
cleanup
0ab0476
@chrstinalin
cleanup
d39b28b
@chrstinalin
cleanup
1bd4539
@chrstinalin
documentation
6a5ef5c
@chrstinalin
import order
9e08699
@chrstinalin
redundant import
7dff675
@chrstinalin
getAddonSlug updates from import-reviewer-url
af8f1c7
@chrstinalin
commit
bc95157
@chrstinalin
updated cache name
ebe9ac3
@chrstinalin chrstinalin marked this pull request as draft July 3, 2024 15:14
@codecov-commenter
Copy link

codecov-commenter commented Jul 3, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 71.11111% with 52 lines in your changes missing coverage. Please review.

Project coverage is 91.62%. Comparing base (0ffe0d0) to head (f93022c).

Files Patch % Lines
src/controller/commentCacheController.ts 42.85% 20 Missing ⚠️
src/views/addonView.ts 26.08% 17 Missing ⚠️
src/controller/addonController.ts 84.37% 10 Missing ⚠️
src/controller/urlController.ts 66.66% 4 Missing ⚠️
src/controller/directoryController.ts 80.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##           diff-bar      #68      +/-   ##
============================================
- Coverage     92.95%   91.62%   -1.33%     
============================================
  Files            27       27              
  Lines          2754     2867     +113     
  Branches        169      172       +3     
============================================
+ Hits           2560     2627      +67     
- Misses          190      236      +46     
  Partials          4        4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chrstinalin chrstinalin changed the title Source Code Compatibility Source Code Package Compatibility Jul 3, 2024
@chrstinalin chrstinalin marked this pull request as ready for review July 4, 2024 18:50
@chrstinalin chrstinalin changed the base branch from icon-font to diff-bar July 8, 2024 18:26
willdurand
willdurand requested changes Jul 9, 2024
View reviewed changes
Copy link
Member

@willdurand willdurand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is not a feature implemented in code-manager, let's put this PR on hold.

@chrstinalin chrstinalin force-pushed the diff-bar branch 2 times, most recently from 80ad54d to aaca245 Compare July 9, 2024 16:50
@chrstinalin chrstinalin deleted the branch diff-bar July 15, 2024 14:56
@willdurand willdurand deleted the diff-source branch August 1, 2024 12:24
@chrstinalin chrstinalin restored the diff-source branch August 1, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willdurand willdurand willdurand requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Diff Source Code Packages Open a Source Code Package for Review
3 participants
@chrstinalin @codecov-commenter @willdurand