Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Code Package Compatibility #68

Closed
wants to merge 82 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
82 commits
Select commit Hold shift + click to select a range
a7caa5d
readonly
chrstinalin Jun 5, 2024
0e62891
readonly functionality
chrstinalin Jun 7, 2024
64d0162
extension and types files readonly
chrstinalin Jun 7, 2024
a40f243
linter
chrstinalin Jun 7, 2024
2cc9a7b
removed unneeded file
chrstinalin Jun 7, 2024
05247ca
better comments
chrstinalin Jun 7, 2024
b2e8bd1
testing
chrstinalin Jun 10, 2024
730b0f2
testing reviewRootDir
chrstinalin Jun 10, 2024
fa3c3e0
guid typo
chrstinalin Jun 10, 2024
61bae65
guid fix without work from separate branch
chrstinalin Jun 10, 2024
e8ffec2
Merge branch 'main' into readonly-linter
chrstinalin Jun 12, 2024
02e10b6
fixed merge
chrstinalin Jun 12, 2024
e299da5
reviewer url compatibility
chrstinalin May 29, 2024
87c7e76
test friendly delimiter const
chrstinalin May 29, 2024
b2b762e
allow addon slug errors to properly appear rather than silently throw…
chrstinalin May 30, 2024
895a8c8
enum
chrstinalin Jun 12, 2024
faca00f
scaffolding
chrstinalin Jun 12, 2024
17ab860
refactoring
chrstinalin Jun 13, 2024
0e5bd1c
controllers
chrstinalin Jun 13, 2024
555279a
controller
chrstinalin Jun 14, 2024
2cbf2fd
connections
chrstinalin Jun 14, 2024
0ab0476
cleanup
chrstinalin Jun 14, 2024
d39b28b
cleanup
chrstinalin Jun 14, 2024
1bd4539
cleanup
chrstinalin Jun 14, 2024
6a5ef5c
documentation
chrstinalin Jun 14, 2024
9e08699
import order
chrstinalin Jun 14, 2024
7dff675
redundant import
chrstinalin Jun 14, 2024
af8f1c7
getAddonSlug updates from import-reviewer-url
chrstinalin Jun 17, 2024
bc95157
commit
chrstinalin Jun 17, 2024
ebe9ac3
updated cache name
chrstinalin Jun 17, 2024
6b7a066
new test
chrstinalin Jun 17, 2024
28ec87f
sort
chrstinalin Jun 17, 2024
06b70c6
formatted
chrstinalin Jun 18, 2024
0e9da4b
moved promise
chrstinalin Jun 18, 2024
470a5ac
addonController, commentCacheController tests
chrstinalin Jun 18, 2024
4344d30
convert rangeController to static class rangeHelper
chrstinalin Jun 18, 2024
388a7fc
src updates
chrstinalin Jun 19, 2024
b5ed15e
controller, helper, model tests
chrstinalin Jun 19, 2024
9995d32
converted tests
chrstinalin Jun 20, 2024
5d91b25
removed commenting section, formatting
chrstinalin Jun 20, 2024
0708dde
reverted promise resolution for downloadAddon
chrstinalin Jun 21, 2024
7c5ab7b
reverted promise resolution for downloadAddon
chrstinalin Jun 21, 2024
6cbc970
removed config dependency from diffController as it needs to be calle…
chrstinalin Jun 24, 2024
cffd54f
removed config dependencies for directoryController
chrstinalin Jun 24, 2024
1e6e3ea
svg
chrstinalin Jun 24, 2024
db0f601
sidebar
chrstinalin Jun 24, 2024
09a5242
Update package.json
chrstinalin Jun 24, 2024
8b72090
refresh
chrstinalin Jun 24, 2024
097d3e0
update sidebar on download
chrstinalin Jun 24, 2024
aa36226
icons
chrstinalin Jun 25, 2024
2a8bf90
svg
chrstinalin Jun 24, 2024
b42fb33
sidebar icons
chrstinalin Jun 25, 2024
a7e8d81
returned jpeg
chrstinalin Jun 25, 2024
937488b
delete svgs
chrstinalin Jun 25, 2024
e9f4db5
updates from #55
chrstinalin Jun 26, 2024
7178812
updates from #55
chrstinalin Jun 26, 2024
2ae2c07
updates from #55
chrstinalin Jun 26, 2024
67da936
testing
chrstinalin Jun 26, 2024
cef22a4
testing
chrstinalin Jun 26, 2024
1ec5426
extension.test.ts
chrstinalin Jun 26, 2024
df3a2b5
extension.test.ts
chrstinalin Jun 26, 2024
8ba4b13
testing
chrstinalin Jun 26, 2024
e25b49a
Merge branch 'diff-bar' into icon-font
chrstinalin Jun 26, 2024
2e0557f
uncomment
chrstinalin Jun 26, 2024
48ffca5
source code functionality
chrstinalin Jul 3, 2024
401cbfb
compatibility tests
chrstinalin Jul 3, 2024
acfd678
test
chrstinalin Jul 3, 2024
5b4d5a1
removed non functional tests. should add back on future date
chrstinalin Jul 3, 2024
886b064
removed tests
chrstinalin Jul 3, 2024
a717a1f
test compatibility
chrstinalin Jul 3, 2024
6ba629e
more tests
chrstinalin Jul 3, 2024
7c6705f
Merge branch 'refactor' into diff-bar
chrstinalin Jul 3, 2024
839fee8
command rename
chrstinalin Jul 4, 2024
d746892
moved function from extension.ts inward
chrstinalin Jul 4, 2024
37a352f
formatting
chrstinalin Jul 8, 2024
9a9fa82
delete functionality
chrstinalin Jul 8, 2024
d54430f
formatting
chrstinalin Jul 8, 2024
1df9db9
Switched to Icon Fonts Rather Than SVG (#66)
chrstinalin Jul 8, 2024
0ffe0d0
Merge branch 'main' into diff-bar
chrstinalin Jul 8, 2024
d9cd42a
Merge branch 'diff-bar' into diff-source
chrstinalin Jul 8, 2024
7e5507b
Removed duplicate delete function
chrstinalin Jul 8, 2024
f93022c
Missing bracket
chrstinalin Jul 8, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
File renamed without changes
5 changes: 0 additions & 5 deletions media/commentIcons/close.svg

This file was deleted.

5 changes: 0 additions & 5 deletions media/commentIcons/close_inverse.svg

This file was deleted.

5 changes: 0 additions & 5 deletions media/commentIcons/edit.svg

This file was deleted.

5 changes: 0 additions & 5 deletions media/commentIcons/edit_inverse.svg

This file was deleted.

6 changes: 0 additions & 6 deletions media/commentIcons/export.svg

This file was deleted.

6 changes: 0 additions & 6 deletions media/commentIcons/export_inverse.svg

This file was deleted.

6 changes: 0 additions & 6 deletions media/commentIcons/link.svg

This file was deleted.

8 changes: 0 additions & 8 deletions media/commentIcons/link_inverse.svg

This file was deleted.

Binary file added media/tabler-icons.woff
Binary file not shown.
173 changes: 152 additions & 21 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,64 @@
],
"main": "./dist/extension.js",
"contributes": {
"icons": {
"assay-edit": {
"description": "edit",
"default": {
"fontPath": "media/tabler-icons.woff",
"fontCharacter": "\\eb04"
}
},
"assay-export": {
"description": "export",
"default": {
"fontPath": "media/tabler-icons.woff",
"fontCharacter": "\\eb47"
}
},
"assay-share": {
"description": "share",
"default": {
"fontPath": "media/tabler-icons.woff",
"fontCharacter": "\\eb21"
}
},
"assay-delete": {
"description": "close",
"default": {
"fontPath": "media/tabler-icons.woff",
"fontCharacter": "\\eb55"
}
},
"assay-add": {
"description": "add",
"default": {
"fontPath": "media/tabler-icons.woff",
"fontCharacter": "\\eb0b"
}
},
"assay-addon": {
"description": "addon",
"default": {
"fontPath": "media/tabler-icons.woff",
"fontCharacter": "\\eb10"
}
},
"assay-refresh": {
"description": "refresh",
"default": {
"fontPath": "media/tabler-icons.woff",
"fontCharacter": "\\eb13"
}
},
"assay-view": {
"description": "view",
"default": {
"fontPath": "media/tabler-icons.woff",
"fontCharacter": "\\fb79"
}
}
},
"configuration": {
"title": "Assay",
"properties": {
Expand All @@ -43,6 +101,37 @@
}
},
"menus": {
"view/title": [
{
"command": "assay.get",
"group": "navigation@2",
"when": "view == assay.xpiCommands || view === assay.srcCommands"
},
{
"command": "assay.refresh",
"group": "navigation@1",
"when": "view == assay.xpiCommands || view === assay.srcCommands"
}
],
"view/item/context": [
{
"command": "assay.sidebarDiff",
"when": "viewItem !== guidDirectory && (view == assay.xpiCommands || view === assay.srcCommands) && listDoubleSelection"
},
{
"command": "assay.sidebarDelete",
"when": "(view == assay.xpiCommands || view === assay.srcCommands)"
},
{
"command": "assay.sidebarDelete",
"when": "view == assayCommands"
},
{
"command": "assay.viewAddon",
"group": "inline",
"when": "viewItem !== guidDirectory && (view == assay.xpiCommands || view === assay.srcCommands)"
}
],
"explorer/context": [
{

Expand All @@ -51,7 +140,6 @@
"when": "assay.commentsEnabled && explorerResourceIsFolder && listDoubleSelection"
},
{

"command": "assay.exportCommentsFromContext",
"group": "navigation",
"when": "assay.commentsEnabled && explorerResourceIsFolder"
Expand Down Expand Up @@ -112,14 +200,38 @@
}
]
},
"viewsContainers": {
"activitybar": [
{
"id": "assay-menu",
"title": "Assay",
"icon": "media/assay.svg"
}
]
},
"views": {
"explorer": [
"assay-menu": [
{
"id": "assay.xpiCommands",
"name": "XPI Packages"
},
{
"id": "assayCommands",
"name": "Assay"
"id": "assay.srcCommands",
"name": "Source Packages",
"visibility": "collapsed"
}
]
},
"viewsWelcome": [
{
"view": "assay.xpiCommands",
"contents": "You do not have any addons installed.\n[+ Review New Addon](command:assay.get)\n In order to use Assay, you must generate an API key and secret in the [Reviewer Tools](https://addons.mozilla.org/en-US/firefox/) section of AMO. \n[Enter API Key](command:assay.getApiKey)\n[Enter Secret](command:assay.getSecret)\nYou can [Test API Credentials](command:assay.testApiCredentials) if needed.\nNew to Assay? [View Instructions](command:assay.welcome)"
},
{
"view": "assay.srcCommands",
"contents": "No source code packages installed."
}
],
"commands": [
{
"command": "assay.welcome",
Expand All @@ -141,6 +253,37 @@
"command": "assay.checkForUpdates",
"title": "(Assay) Check For Updates"
},
{
"command": "assay.get",
"title": "(Assay) Review New Addon",
"icon": "$(assay-add)"
},
{
"command": "assay.refresh",
"title": "Refresh Addons",
"icon": "$(assay-refresh)"
},
{
"command": "assay.sidebarDiff",
"title": "Open Versions in Diff Tool"
},
{
"command": "assay.sidebarDelete",
"title": "Delete"
},
{
"command": "assay.viewAddon",
"title": "View Addon in New Window",
"icon": "$(assay-view)"
},
{
"command": "assay.getApiKey",
"title": "(Assay) Enter API Key"
},
{
"command": "assay.getSecret",
"title": "(Assay) Enter Secret Key"
},
{
"command": "assay.copyLinkFromReply",
"title": "Copy Link"
Expand All @@ -152,18 +295,12 @@
{
"command": "assay.editComment",
"title": "Edit Comment",
"icon": {
"dark": "media/commentIcons/edit_inverse.svg",
"light": "media/commentIcons/edit.svg"
}
"icon": "$(assay-edit)"
},
{
"command": "assay.deleteComment",
"title": "Delete",
"icon": {
"dark": "media/commentIcons/close_inverse.svg",
"light": "media/commentIcons/close.svg"
}
"icon": "$(assay-delete)"
},
{
"command": "assay.saveComment",
Expand All @@ -180,18 +317,12 @@
{
"command": "assay.exportComments",
"title": "Export Version Comments",
"icon": {
"dark": "media/commentIcons/export_inverse.svg",
"light": "media/commentIcons/export.svg"
}
"icon": "$(assay-export)"
},
{
"command": "assay.copyLinkFromThread",
"title": "Copy Link",
"icon": {
"dark": "media/commentIcons/link_inverse.svg",
"light": "media/commentIcons/link.svg"
}
"icon": "$(assay-share)"
}
]
},
Expand Down Expand Up @@ -255,4 +386,4 @@
"jsonwebtoken": "^9.0.1",
"jszip": "^3.10.1"
}
}
}
Loading