-
Notifications
You must be signed in to change notification settings - Fork 124
feat(DENG-9188) Add BigConfig checks to targeted stable tables #8436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
sql_generators/stable_tables_targeted/templates/stable_tables_targeted.metadata.yaml
Outdated
Show resolved
Hide resolved
|
Two things that may need to be taken into account:
|
This comment has been minimized.
This comment has been minimized.
|
Looking at the diff the |
sql_generators/stable_tables_monitoring/templates/stable_tables_monitoring.metadata.yaml
Outdated
Show resolved
Hide resolved
sql_generators/stable_tables_monitoring/templates/stable_tables_monitoring.bigconfig.yml
Outdated
Show resolved
Hide resolved
sql_generators/stable_tables_monitoring/stable_tables_monitoring.py
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
Integration report for "show example of stable table in readme"
|
kik-kik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could consider adding a test for this just to make sure the rendering of templates is working as expected. Would also be nice to have a test covering the new case inside metadata.py
* add bigconfig checks to targeted stable tables * add readme file * Update README.md * rename to stable_tables_monitoring and add feature to skip deployments * delete old directory * re add files * fix typo * rename files and add stable table datasets to config file * show example of stable table in readme --------- Co-authored-by: Philip Lee <[email protected]>
Description
This PR adds the feature to add BigConfig monitoring checks (freshness and volume) to a targeted set of stable tables.
Approach - apply this change to an asset that is currently not in use
This PR will create the metadata and bigconfig yaml files for
moz-fx-data-shared-prod.mozilla_vpn_external.waitlist_v1. This table has not been queried in the last 6 months and does not have any downstream tables or Looker Explores.Output:

Related Tickets & Documents
Reviewer, please follow this checklist