Metadata label and CI validation for table levels based on medallion architecture #8522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… medallion architecture.
kwindau
approved these changes
Nov 29, 2025
kik-kik
reviewed
Dec 1, 2025
kik-kik
reviewed
Dec 1, 2025
kik-kik
reviewed
Dec 1, 2025
kik-kik
reviewed
Dec 1, 2025
akkomar
previously requested changes
Dec 1, 2025
Collaborator
akkomar
left a comment
akkomar
left a comment
There was a problem hiding this comment.
Requesting changes because of existing approval with test failures.
akkomar
reviewed
Dec 3, 2025
| ] | ||
|
|
||
| if "level" in metadata: | ||
| level = metadata["level"] |
Collaborator
There was a problem hiding this comment.
I think if you follow Sean's suggestion you could convert to AssetLevel here:
Suggested change
| level = metadata["level"] | |
| level = AssetLevel(metadata["level"]) |
This way invalid values fail at parse time and you don't need a separate validator above.
Contributor
Author
There was a problem hiding this comment.
Very tidy, though I'd personally prefer the detailed debugging messages in the validator, in case of CI failures.
wwyc
reviewed
Dec 3, 2025
| return True | ||
|
|
||
|
|
||
| def validate_asset_level(query_dir, metadata): |
Contributor
Author
There was a problem hiding this comment.
In my opinion, it makes sense to require owners, at the minimum for level Gold.
Could you add it to Requirements for each level for which levels you think it makes sense?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables adding a metadata label to set the table level as one of [gold, silver, bronze].
Related Tickets & Documents
Reviewer, please follow this checklist