Skip to content

Conversation

@ArezouAmini
Copy link
Collaborator

No description provided.

@ArezouAmini ArezouAmini requested review from marco-c and suhaibmujahid and removed request for marco-c and suhaibmujahid June 11, 2025 04:56
Copy link
Member

@suhaibmujahid suhaibmujahid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ArezouAmini Thank you for submitting the PR!

Could you please clarify the relation between the three classes that you added?

Comment on lines +4 to +7
import torch
from datasets import Dataset
from torch.nn.functional import softmax
from transformers import (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think some of the dependencies are not in the requirements.json.

self.tmpdir = tmpdir

@abstractmethod
def train_test_split(self, data, test_size=0.5, random_split=True): ...
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What should the data look like? I do not see the method used anywhere!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants