Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove delayed run checks #336

Merged
merged 2 commits into from
Jan 27, 2025
Merged

Remove delayed run checks #336

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
267f7e6
moz_kinto_publisher: remove obsolete "big stash" test
jschanck Jan 25, 2025
041fc6c
moz_kinto_publisher: remove delayed run checks
jschanck Jan 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 0 additions & 15 deletions moz_kinto_publisher/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -901,14 +901,6 @@ def crlite_verify_record_consistency(*, existing_records, channel):
if maxHeight != len(existing_records) - 1:
raise ConsistencyException(f"Multiple filter descendents: {full_filters}")

# There should be no long gaps between record timestamps
allowed_delta = timedelta(hours=8)
timestamps = [timestamp_from_record(r) for r in existing_records]
for x, y in zip(timestamps, timestamps[1:]):
if y - x > allowed_delta:
raise ConsistencyException(f"Too-wide a delta: {y-x}")


def crlite_verify_run_id_consistency(*, run_db, identifiers_to_check, channel):
# The runs should be complete.
for r in identifiers_to_check:
Expand All @@ -927,13 +919,6 @@ def crlite_verify_run_id_consistency(*, run_db, identifiers_to_check, channel):
if x > y:
raise ConsistencyException(f"Out-of-order timestamp: {ts}")

# There should be no large gaps between run timestamps.
allowed_delta = timedelta(hours=8)
for x, y in zip(ts, ts[1:]):
if y - x > allowed_delta:
raise ConsistencyException(f"Too-wide a delta: {y-x}")


def crlite_determine_publish(*, existing_records, run_db, channel):
assert len(run_db) > 0, "There must be run identifiers"

Expand Down
28 changes: 0 additions & 28 deletions moz_kinto_publisher/test_publisher.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,34 +358,6 @@ def test_publish_multiple_stashes(self):
self.assertEqual(None, rw_client.publish())
self.assertEqual(db_run_ids, rw_client.get_run_ids())

def test_publish_big_stash(self):
# A big stash should cause us to publish a new filter
rw_client = MockClient()
db = MockRunDB()
# publish a full filter
db_run_ids = [db.add_run(filter_size=10, stash_size=0)]
self.assertEqual(db_run_ids[0], rw_client.publish())
self.assertEqual(db_run_ids, rw_client.get_run_ids())
# add a run with a large stash, we should publish a full filter
db_run_ids += [db.add_run(filter_size=10, stash_size=1000)]
self.assertEqual(db_run_ids[-1], rw_client.publish())
self.assertEqual([db_run_ids[-1]], rw_client.get_run_ids())

def test_publish_delayed_run(self):
rw_client = MockClient()
db = MockRunDB()
db_run_ids = [db.add_run()]
self.assertEqual(db_run_ids[0], rw_client.publish())
self.assertEqual(db_run_ids, rw_client.get_run_ids())
# add a stash from a run that was delayed
db_run_ids += [db.add_run(delta=timedelta(hours=12))]
self.assertEqual(None, rw_client.publish())
self.assertEqual(db_run_ids, rw_client.get_run_ids())
# the next consistency check will fail, and a full filter will be published
db_run_ids += [db.add_run()]
self.assertEqual(db_run_ids[2], rw_client.publish())
self.assertEqual([db_run_ids[2]], rw_client.get_run_ids())

def test_publish_ten_day_old_filter(self):
# a new filter should be published every 10 days
rw_client = MockClient()
Expand Down