ct-fetch: support for tiled logs #359
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jschanck
changed the title
mozkeeler
approved these changes
Jul 18, 2025
|
While testing in the dev instance we ran out of memory in Redis (tiled logs are fast...). Turns out there was also a bug where log state updates were sent to Redis on a different thread than certificate entries, so they were not guaranteed to be ordered correctly. Hence, on something like an OOM failure, the log state in redis could be ahead of the log entries that had actually been written to cache. I've added a couple patches here to fix this. Redis is single-threaded so there's no performance penalty in sequencing operations in |
mozkeeler
approved these changes
Jul 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #358