cmake: fix build with ninja generator #807
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -345,6 +345,7 @@ if(USE_PULSE AND USE_PULSE_RUST) | |||
| DOWNLOAD_COMMAND "" | |||
| CONFIGURE_COMMAND "" | |||
| BUILD_COMMAND cargo build --features=gecko-in-tree COMMAND cargo build --release --features=gecko-in-tree | |||
| BUILD_BYPRODUCTS "${PROJECT_SOURCE_DIR}/src/cubeb-pulse-rs/target/$<IF:$<CONFIG:Debug>,debug,release>/libcubeb_pulse.a" | |||
There was a problem hiding this comment.
drive-by: will this work if libcubeb-pulse is cross-compiled for a different architecture?
There was a problem hiding this comment.
(also, thanks for the patch!)
There was a problem hiding this comment.
drive-by: will this work if libcubeb-pulse is cross-compiled for a different architecture?
Why not? It's the same file that is referenced by the target_link_libraries call below.
There was a problem hiding this comment.
Ah right, thanks for pointing that out. I think that's broken, too (cross-compiled rust would live in target/arch-triple/{debug,release}, if i recall correctly), so this won't make it broken in any new ways.
|
cc @kinetiknz |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix this error when using
Ninjagenerator andRustbackendcmake -G Ninja -D BUILD_RUST_LIBS=ON ...Because of this and that.