This repository was archived by the owner on May 27, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We might not want
|
I'd suggest eslint's recommended configuration combined with eslint-prettier. The recommended config handles most of correctness rules, and prettier handles formatting. It's not super opinionated like airbnb, but still has a decent set of rules. This is what I did in mozjexl |
rehandalal
approved these changes
Apr 4, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wheee! r+
magopian
added a commit
to magopian/delivery-console
that referenced
this pull request
Apr 4, 2018
rehandalal
added a commit
that referenced
this pull request
Apr 4, 2018
Fixup following the merge of PR #75
This was referenced Apr 5, 2018
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34
eslint
to project (let's use the one bundled by default with CRA)prettier-eslint
, change package.json scripts accordingly