Skip to content
This repository has been archived by the owner on Jul 9, 2024. It is now read-only.

jsctags works with nodejs 0.10.x again. #54

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tow8ie
Copy link

@tow8ie tow8ie commented Apr 19, 2013

The issue #52 by @doovoochild has been closed, but the fix described by @chilkari in the discussion hasn’t been patched into master. Here is this patch.

Applied patch as described in
mozilla#52.
@renovatorruler
Copy link

I second this pull request. Just applied the patch to mozilla/doctorjs and jsctags works beautifully.

@chilkari
Copy link

Thanks, tow8le. I should have put a real patch together. Thanks for submitting. Naturally, it worked for me, so if this is helpful to others, I also support request.

@prasincs
Copy link

Worked for me too. Definitely supported.

@thatguydan
Copy link

+1

2 similar comments
@dmcinnes
Copy link

dmcinnes commented Jun 4, 2013

👍

@lancelotj
Copy link

+1

@mitermayer
Copy link

+1 please merge that

@tosyu
Copy link

tosyu commented Jun 18, 2013

+1

@sangwook-kim
Copy link

+1.

I should have kept this issue opened. Sorry.

@kredmer
Copy link

kredmer commented Jun 19, 2013

+1

1 similar comment
@pose
Copy link

pose commented Jun 25, 2013

👍

@jojojames
Copy link

Another +1 here.

@qzg
Copy link

qzg commented Jun 29, 2013

+1 Works.

@wlaurance
Copy link

👍

@iammerrick
Copy link

Please?

@mitermayer
Copy link

@tow8ie i would update this pull to this:

 exports.Tags = function (initialTags) {
     this.tags = initialTags || this.tags;
     this.init();
 };

 exports.Tags.prototype = Object.create(Object.prototype, Trait.compose(Trait({
        tags: [],

The reason why i would do that is because you would still allow Tags to be instantiated using an array of initial tags, maybe doing that would get them this pull finaly merged

@francoisjacques
Copy link

@mitermayer approach works well while respecting the initialTags case.

@tony
Copy link

tony commented Dec 23, 2013

@mozilla Hey, if anyone is an administer over here - there hasn't been any movement here in a while, can we have a status report on this package? This is an important package to a lot of people. Thanks.

@baongoc124
Copy link

+1

@michelalbers
Copy link

👍 +1

@kalinichenko
Copy link

+1

@leostratus
Copy link

Will it help if a Mozillian gets a +1 in here? I'm getting questions about this PR and this isn't even a project I work on. HEYOOOO can we get a merge all up in this?

+1

@sKatsuya
Copy link

sKatsuya commented Mar 7, 2014

great! 👍

@Salles-FA
Copy link

+1

@mitermayer
Copy link

I was wondering, if depending the license we could all fork it up and continue its development since it looks like this is not getting merged any time soon

@yang-ling
Copy link

This project needs new leadership.
DoctorJS looking for new leadership

@rocknrollMarc
Copy link

Ive installed jsctags on like 4 new machienes and had to do this quickfix everytime why dont you update the code? Is there a good reason for that?

exports.Tags = function (initialTags) {
this.tags = initialTags || this.tags;
this.init();
};

exports.Tags.prototype = Object.create(Object.prototype, Trait.compose(Trait({
tags: [],

Every kind of newbie is going to loose his hair, I remember I nearly did.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.