-
Notifications
You must be signed in to change notification settings - Fork 67
jsctags works with nodejs 0.10.x again. #54
base: master
Are you sure you want to change the base?
Conversation
Applied patch as described in mozilla#52.
I second this pull request. Just applied the patch to mozilla/doctorjs and jsctags works beautifully. |
Thanks, tow8le. I should have put a real patch together. Thanks for submitting. Naturally, it worked for me, so if this is helpful to others, I also support request. |
Worked for me too. Definitely supported. |
+1 |
2 similar comments
👍 |
+1 |
+1 please merge that |
+1 |
+1. I should have kept this issue opened. Sorry. |
+1 |
1 similar comment
👍 |
Another +1 here. |
+1 Works. |
👍 |
Please? |
@tow8ie i would update this pull to this: exports.Tags = function (initialTags) {
this.tags = initialTags || this.tags;
this.init();
};
exports.Tags.prototype = Object.create(Object.prototype, Trait.compose(Trait({
tags: [], The reason why i would do that is because you would still allow Tags to be instantiated using an array of initial tags, maybe doing that would get them this pull finaly merged |
@mitermayer approach works well while respecting the initialTags case. |
@mozilla Hey, if anyone is an administer over here - there hasn't been any movement here in a while, can we have a status report on this package? This is an important package to a lot of people. Thanks. |
+1 |
👍 +1 |
+1 |
Will it help if a Mozillian gets a +1 in here? I'm getting questions about this PR and this isn't even a project I work on. HEYOOOO can we get a merge all up in this? +1 |
great! 👍 |
+1 |
I was wondering, if depending the license we could all fork it up and continue its development since it looks like this is not getting merged any time soon |
This project needs new leadership. |
Ive installed jsctags on like 4 new machienes and had to do this quickfix everytime why dont you update the code? Is there a good reason for that? exports.Tags = function (initialTags) { exports.Tags.prototype = Object.create(Object.prototype, Trait.compose(Trait({ Every kind of newbie is going to loose his hair, I remember I nearly did. |
The issue #52 by @doovoochild has been closed, but the fix described by @chilkari in the discussion hasn’t been patched into master. Here is this patch.