feat(nimbus): Draft/Preview/Review workflow #11932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yashikakhurana
requested review from
jaredlockhart and
freshstrangemusic
as code owners
yashikakhurana
changed the title
|
wait for review, fixing some layouts |
jaredlockhart
requested changes
Dec 11, 2024
...er/experimenter/nimbus_ui_new/templates/nimbus_experiments/launch_with_preview_controls.html
Outdated
Show resolved
Hide resolved
jaredlockhart
previously requested changes
Jan 13, 2025
There was a problem hiding this comment.
Ya this is looking great. Very nice and succinct changes, great tests, works great locally. Couple last points about the tests but this is pretty much there, amazing thank you @yashikakhurana 🙏 🎉
|
Oh also there's a little gap on the right of the timeline here, see if you can get rid of that: 
|
Fixed it |
jaredlockhart
previously requested changes
Jan 27, 2025
jaredlockhart
approved these changes
Jan 28, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 28, 2025
Because We want to include workflow on the new summary page: - Send draft to preview - preview to review - preview to draft - review to draft - cancel review This commit - Adds the preview, review workflow Fixes #11757 https://github.com/user-attachments/assets/cb7978af-aa85-45a3-a40d-0d890c94bb54 --------- Co-authored-by: Jared Lockhart <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
We want to include workflow on the new summary page:
This commit
Fixes #11757
Screen.Recording.2024-12-24.at.12.26.47.PM.mov