Skip to content

Conversation

soncuteanca
Copy link
Collaborator

@soncuteanca soncuteanca commented Oct 6, 2025

Relevant Links

Bugzilla: 1980159
TestRail: 1756748

Description of Code / Doc Changes

  • Refactoring Downloads test based on best practices doc
  • Attempt Win stabilization - after investigation and consultation, we decided to have it skipped on Windows with a clear motive on the reason.

Process Changes Required

Mark the relevant boxes:

  • Adds a dependency (rerun pipenv install)
  • Changes the BasePage
  • Changes or creates a BOM/POM (name the object model): _
  • Changes CI flow
  • Changes scheduled Beta or DevEdition
  • Changes Git hooks or Github settings
  • Changes L10n harness

Screenshots or Explanations

If you need to explain your code, do it here.

Comments or Future Work

  • After investigation we determine that this test is flaky because on most Windows runners, we don’t have a .doc handler registered. Some potential solutions included: ignore the app name and just assert that Firefox adds the MIME entry (it will still validate the core functionality, just narrowed the scope), keep it skipped, but with a clearer reason, install LibreOffice in CI so the handler is always available.

Workflow Checklist

  • Please request reviewers
  • If this is an unblocker, please post in Slack.
  • If asked to address comments, please resolve conversations.
  • If asked to change code, please re-request review from the person who wanted changes.

Thank you!

vsangereanMOZ
vsangereanMOZ previously approved these changes Oct 8, 2025
Copy link
Collaborator

@vsangereanMOZ vsangereanMOZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mistake by me.

@vsangereanMOZ vsangereanMOZ self-requested a review October 8, 2025 12:29
@soncuteanca soncuteanca marked this pull request as ready for review October 9, 2025 07:41
Copy link
Collaborator

@vsangereanMOZ vsangereanMOZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good

@soncuteanca soncuteanca merged commit 2469906 into main Oct 9, 2025
24 checks passed
@soncuteanca soncuteanca deleted the anca/mime_type_refactoring_stabilization branch October 9, 2025 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants