Merge pull request #16800 from mozilla/FXA-9518

bug(functional-tests): Skip failing smoke tests due to timing issue on redirect to Stage 123 Done
mozilla · Apr 26, 2024 · ef4dd0c · ef4dd0c
2 parents 28cccf3 + 9def89b
commit ef4dd0c
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 4 deletions.
diff --git a/packages/functional-tests/tests/oauth/signin.spec.ts b/packages/functional-tests/tests/oauth/signin.spec.ts
@@ -186,7 +186,11 @@ test.describe('severity-1 #smoke', () => {
       page,
       pages: { login, relier, settings, deleteAccount },
       emails,
-    }) => {
+    }, { project }) => {
+      test.fixme(
+        project.name !== 'local',
+        'FXA-9518 - Timing issue? Fails on stage with `Bad request - unknown state` on L209, unless breakpoint added on L208. Passes when restarting from breakpoint. '
+      );
       const [blockedEmail] = emails;
 
       await target.createAccount(blockedEmail, PASSWORD);
@@ -202,6 +206,7 @@ test.describe('severity-1 #smoke', () => {
       await login.setPassword(PASSWORD);
       await login.submit();
       await login.unblock(blockedEmail);
+      await relier.isLoggedIn();
       await settings.goto();
       await settings.deleteAccountButton.click();
       await deleteAccount.deleteAccount(PASSWORD);

diff --git a/packages/functional-tests/tests/react-conversion/oauthSignin.spec.ts b/packages/functional-tests/tests/react-conversion/oauthSignin.spec.ts
@@ -38,7 +38,11 @@ test.describe('severity-1 #smoke', () => {
     test('verified account with cached login, no email confirmation required', async ({
       credentials,
       pages: { page, relier, signinReact },
-    }) => {
+    }, { project }) => {
+      test.fixme(
+        project.name !== 'local',
+        'FXA-9518 - Timing issues? Fails on stage with `Bad request - unknown state` on L54 and L74, unless breakpoint added on L53 and L72. Passes when restarting from breakpoint.'
+      );
       await relier.goto();
       await relier.clickEmailFirst();
       await expect(page).toHaveURL(/oauth\//);
@@ -70,7 +74,7 @@ test.describe('severity-1 #smoke', () => {
       await expect(page.getByText(credentials.email)).toBeVisible();
       await signinReact.signInButton.click();
 
-      expect(await relier.isLoggedIn()).toBe(true);
+      await relier.isLoggedIn();
     });
 
     test('verified using a cached expired login', async ({

diff --git a/packages/functional-tests/tests/react-conversion/signInRelyingParties.spec.ts b/packages/functional-tests/tests/react-conversion/signInRelyingParties.spec.ts
@@ -59,12 +59,16 @@ test.describe('severity-1 #smoke', () => {
   test('react disconnect RP #1293475', async ({
     credentials,
     pages: { configPage, page, relier, signinReact, settings },
-  }) => {
+  }, { project }) => {
     const config = await configPage.getConfig();
     test.skip(
       config.showReactApp.signInRoutes !== true,
       'Skip tests if React signInRoutes not enabled'
     );
+    test.fixme(
+      project.name !== 'local',
+      'FXA-9518 - Timing issue? Fails on stage with `Bad request - unknown state` on L86, unless breakpoint added on L85. Passes when restarting from breakpoint. '
+    );
 
     await relier.goto();
     await relier.clickEmailFirst();