Bug 1988206 - Record clicks on elements in Shadow DOM #2013
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1988206
Relates to mdn/fred#752
Uses composedPath() to get the original target within a Shadow DOM, rather than the custom element with a Shadow DOM itself (which is what
event.targetis).This should possibly be considered a breaking change: if clients have patched this themselves, by firing
GleanMetrics.recordElementClick();for relevant clicks in Shadow DOMs (as we've done in fred), this change upstream would result in duplicated pings.Tests
I've tested with a local build of glean, I couldn't find any tests with related to this
data-glean-idauto pinging: I'm happy to add a test if pointed in the right direction.Pull Request checklist
glean/folder, run:npm run testRuns all testsnpm run lintRuns all lintersCHANGELOG.mdor an explanation of why it does not need onemozilla/gleanrepository