Bug 1934880 - Provide a public interface so that consumers of glean's RLB can access metric identifiers #3054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamBrouwersHarries
requested review from
rosahbruno
and removed request for
a team
AdamBrouwersHarries
force-pushed
the
Bug1934880
branch
2 times, most recently
from
0c44804 to
31cce47
Compare
|
@badboy Just to check, this is going to make it into today's release, right? |
:D yes! |
badboy
reviewed
Jan 30, 2025
glean-core/src/metrics/mod.rs
Outdated
Comment on lines
249
to
250
| let meta = &self.meta().inner; | ||
| (&meta.name, meta.dynamic_label.as_deref()) |
There was a problem hiding this comment.
We usually identify metrics by their full name (or "base_identifier" in our code), which is category.name (if category exists, which it does for all user metrics). Shouldn't we use the full name in the profiler too?
There was a problem hiding this comment.
Good point - we probably should! Right now, in the implementation, we get the name from FOG_GetMetricIdentifier, which uses gMetricStringTable internally. I think this doesn't include the category, but it would be useful indeed. I'll modify this method to also include the category in the name.
… RLB can access metric identifiers
AdamBrouwersHarries
force-pushed
the
Bug1934880
branch
from
31cce47 to
42833c1
Compare
badboy
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'd like to be able to access the name and label of a dynamic metric in FOG. To do this, glean-core's RLB needs to expose some way for us to actually access the underlying metadata. This PR adds a trait that does precisely this, and exports it through the RLB so that downstream consumers can access it.