-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Replace semi-private fields/methods with actual private ones in src/core/catalog.js
#19964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…core/catalog.js` Additionally, move a couple of "public" fields out of the class constructor and initialize them directly instead.
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/dd00aa2d90f68c2/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/03680eb23687b1f/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/03680eb23687b1f/output.txt Total script time: 29.76 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/dd00aa2d90f68c2/output.txt Total script time: 56.92 mins
|
/botio-linux unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/9a773b9f74f03e8/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/9a773b9f74f03e8/output.txt Total script time: 2.39 mins
|
/botio-linux browsertest |
From: Bot.io (Linux m4)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/c409aafa1d62f5c/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/c409aafa1d62f5c/output.txt Total script time: 15.96 mins
|
Additionally, move a couple of "public" fields out of the class constructor and initialize them directly instead.