fix #989 Redeclaration errors should be SyntaxError, not TypeError. #1530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit dea0e8d6f73fdf2d34e92ae93d6d037d35965fc9.
tuchida
changed the title
tuchida
changed the title
tuchida
commented
Jul 19, 2024
| @@ -21,7 +21,7 @@ function test() | |||
| printBugNumber(BUGNUMBER); | |||
| printStatus (summary); | |||
|
|
|||
| expect = /TypeError: anonymous generator function returns a value/; | |||
| expect = /SyntaxError: anonymous generator function returns a value/; | |||
There was a problem hiding this comment.
Apart from the ECMA specifications, to make the code easier, I also changed the old generator error.
|
This is good and I like it. I merged it locally and resolved the test262 conflicts, and I see that indeed all the changes I just merged to test262.properties are intact, so I'm confident that my merge is correct. Since I did all that and it works, I'm going to close this PR manually and push the changes in a minute. Thanks for all this work! |
|
Merged manually. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #989
I fixed it with 0832dc5. To make it easier to see the improvement, I added tests with f0906a9 and 7dbadd7 in advance. After modification,
TypeErrorwas not thrown, so 7dbadd7 was erased with 9fc4e78. Once the review is complete, I will rebase the commits before merging.