improved date localization #1535
Conversation
rbri
commented
Jul 22, 2024
rbri
commented
- use DateTimeFormatter instead of SimpleDateFormat
- Date.prototype.toLocaleString now handles locales argument
- make the formatter use Context.timezone instead of system default
- ES6: use FormatStyle.SHORT for the formatter to make it behave more like real browsers when Intl.DateTimeFormat is not supported
- Date.prototype.toLocaleString now handles locales argument - make the formatter use Context.timezone instead of system default - ES6: use FormatStyle.SHORT for the formatter to make it behave more like real browsers when Intl.DateTimeFormat is not supported
|
this is the new version of #1491 Source code is unchanged, only applied to the latest code |
|
again fails with java 21 - will have a look |
|
Thanks! I attempted to look at the test results myself, and I only had time
to figure out that it was a more complex problem than I realised.
…On Mon, Jul 22, 2024 at 9:53 AM RBRi ***@***.***> wrote:
again fails with java 21 - will have a look
—
Reply to this email directly, view it on GitHub
<#1535 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAD7I242N6YTUXBJQ5U6RRDZNU2HTAVCNFSM6AAAAABLISPEMWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENBTGQYDGNZZGI>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
Think i found it... only i18n ;-D |
|
@gbrail green now hope it is ok for you and can be merged |
|
Yes -- looks good, I will merge it. It did introduce a few warnings from the (admittedly very pedantic) errorprone plugin. In a future PR someone should clean those up -- it just disagrees sometimes about where to use parenthesis. Just because I'm trying to be a stickler, I'm going to add a commit to fix those warnings, and then I will merge this PR manually and close it. One more thought -- I wonder how much simpler the whole NativeDate class would be if it used the new java.time package instead of doing its own calculations? (Plus we could use Lamba functions instead of the IdScriptableObject and it'd be even better!) |
|
Merged manually. Thanks! |
