Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix test utils #1807

Merged
merged 2 commits into from
Feb 2, 2025
Merged

fix test utils #1807

merged 2 commits into from
Feb 2, 2025

Conversation

ZZZank
Copy link
Contributor

@ZZZank ZZZank commented Jan 31, 2025

    public static <T extends Exception> void assertException(
            final int languageVersion,
            final Class<T> expectedThrowable,
            final String expectedMessage,
            String js) {}
  • There's also a new helper function Utils#lines(String[]) to make writing multi-line scripts easier. Utils.lines("line1", "line2", "line3") equals to "line1\n" + "line2\n" + "line3"

@gbrail
Copy link
Collaborator

gbrail commented Feb 1, 2025

This seems helpful and fine to me. Any thoughts from others? Otherwise I'll merge it soon.

@rbri
Copy link
Collaborator

rbri commented Feb 1, 2025

+1

@gbrail
Copy link
Collaborator

gbrail commented Feb 2, 2025

Thanks for doing this!

@gbrail gbrail merged commit ef6450b into mozilla:master Feb 2, 2025
3 checks passed
@ZZZank ZZZank deleted the test-utils branch February 2, 2025 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants