Skip to content

Fall back to direct cache write if tempfile creation on the same fs fails #2369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

myzhang1029
Copy link

Please see #2288 for the discussion.

Co-authored-by: Alex Overchenko <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Apr 15, 2025

Codecov Report

Attention: Patch coverage is 57.89474% with 8 lines in your changes missing coverage. Please review.

Project coverage is 65.65%. Comparing base (9fb3841) to head (55ca695).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
src/cache/cache.rs 57.89% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2369      +/-   ##
==========================================
- Coverage   67.60%   65.65%   -1.95%     
==========================================
  Files          65       65              
  Lines       35471    35510      +39     
==========================================
- Hits        23979    23313     -666     
- Misses      11492    12197     +705     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants