Skip to content

fix: Chrome not opening special chrome URLs or extension specific pages #2774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
+1 −11
Open

fix: Chrome not opening special chrome URLs or extension specific pages #2774

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
a163a3c
bug-1979 partial fix
kodergeek Sep 22, 2021
2f86d4a
fix: Fixed Chrome Not Opening Extensions Pages provided in URL
kodergeek Sep 28, 2021
d485a71
Remove unused ws message handling from bg.js
kodergeek Sep 28, 2021
8ca4550
Fixed PR issues and added unit test for special urls
kodergeek Oct 3, 2021
7b56d10
Remove Code duplication issue and fix unit tests
kodergeek Oct 9, 2021
ce683bb
Merge branch 'bug-1979' into fix-1979-final
dleetr Jun 3, 2023
be140d7
fix: Add extension pages to special start url case handler
dleetr Jun 3, 2023
e2793b4
style: Fixes from prettier-dev
dleetr Jun 3, 2023
a0d19dd
Merge branch 'master' of https://github.com/mozilla/web-ext into fix-…
dleetr Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions src/extension-runners/chromium.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,15 +299,6 @@ export class ChromiumExtensionRunner {
chromeFlags.push(`--profile-directory=${profileDirName}`);
}

let startingUrl;
if (this.params.startUrl) {
const startingUrls = Array.isArray(this.params.startUrl)
? this.params.startUrl
: [this.params.startUrl];
startingUrl = startingUrls.shift();
chromeFlags.push(...startingUrls);
}

this.chromiumInstance = await this.chromiumLaunch({
chromePath: chromiumBinary,
chromeFlags,
Expand Down
3 changes: 1 addition & 2 deletions tests/unit/test-extension-runners/test.chromium.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,6 +252,7 @@ describe('util/extension-runners/chromium', async () => {
'--enable-unsafe-extension-debugging',
'url2',
'url3',
`--load-extension=${reloadManagerExtension},/fake/sourceDir`,
],
startingUrl: 'url1',
});
Expand Down Expand Up @@ -281,8 +282,6 @@ describe('util/extension-runners/chromium', async () => {
'--arg1',
'arg2',
'--arg3',
'url2',
'url3',
],
startingUrl: 'url1',
});
Expand Down