Skip to content

Bug 1970809 - Add comm-esr140, comm-beta, and comm-release to searchfox#282

Open
dandarnell wants to merge 4 commits into
mozsearch:masterfrom
dandarnell:bug1970809
Open

Bug 1970809 - Add comm-esr140, comm-beta, and comm-release to searchfox#282
dandarnell wants to merge 4 commits into
mozsearch:masterfrom
dandarnell:bug1970809

Conversation

@dandarnell
Copy link
Copy Markdown

@dandarnell dandarnell commented Aug 5, 2025

This patch adds the new Thunderbird ESR to searchfox, in addition to comm-beta and comm-release.

Comment thread config2.json Outdated
Comment thread config2.json
@dandarnell dandarnell requested a review from asutherland August 6, 2025 00:21
@darktrojan
Copy link
Copy Markdown

FYI, comm-release is also not on searchfox.

@dandarnell dandarnell changed the title Bug 1970809 - Add comm-esr140 to searchfox Bug 1970809 - Add comm-esr140, comm-beta, and comm-release to searchfox Aug 11, 2025
@dandarnell
Copy link
Copy Markdown
Author

dandarnell commented Aug 11, 2025

I've added comm-beta and comm-release too, since both are missing from searchfox currently and the code to add them is near-identical to comm-esr140.

@asutherland
Copy link
Copy Markdown
Contributor

asutherland commented Aug 11, 2025

release2 is currently a bit overloaded and had to have its disk limit bumped, so I don't think we can support more than one additional comm tree there right now. https://bugzilla.mozilla.org/show_bug.cgi?id=1878998 ended up primarily concerned about semantic indexing from my end, but I think it probably makes sense to extract all the comm-* trees out to a new config6 and then if (in the future) semantic indexing happens for multiple trees, some of those can be extracted out to a new configN depending on what that does to disk usage and indexing time and RAM thrashing. (I talked about TB having 2 configs on the bug, but as long as there's no semantic indexing and with the recent changes that supported config2 hitting its limit, we can probably make 1 machine work for now.)

I'll take care of that though since I'm currently finishing up juggling the firefox-* stuff and am going to be introducing a config6 for that temporarily and I can evolve that, plus there's some manual steps for the tarballs and the ELB rule changes that I can multitask.

@dandarnell
Copy link
Copy Markdown
Author

release2 is currently a bit overloaded and had to have its disk limit bumped, so I don't think we can support more than one additional comm tree there right now. https://bugzilla.mozilla.org/show_bug.cgi?id=1878998 ended up primarily concerned about semantic indexing from my end, but I think it probably makes sense to extract all the comm-* trees out to a new config6 and then if (in the future) semantic indexing happens for multiple trees, some of those can be extracted out to a new configN depending on what that does to disk usage and indexing time and RAM thrashing. (I talked about TB having 2 configs on the bug, but as long as there's no semantic indexing and with the recent changes that supported config2 hitting its limit, we can probably make 1 machine work for now.)

I'll take care of that though since I'm currently finishing up juggling the firefox-* stuff and am going to be introducing a config6 for that temporarily and I can evolve that, plus there's some manual steps for the tarballs and the ELB rule changes that I can multitask.

I was actually unfamiliar with the previous effort to introduce semantic indexing for Rust and C++ (and that bug). We can likely do without that in the medium-term future, as simply having comm-release and comm-beta on searchfox would be a huge boon regardless.

So, if I understand correctly, it should be possible to handle all three new trees on one machine, so long as semantic indexing for Rust/C++ is left out and comm-* repos are broken out into a new config? I can modify this PR myself after config6 is ready, if you would like me to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants