Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

options: default to --prefetch-playlist=yes #15378

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions DOCS/interface-changes/prefetch-playlist.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
change `--prefetch-playlist`'s default to `yes`
8 changes: 1 addition & 7 deletions DOCS/man/options.rst
Original file line number Diff line number Diff line change
Expand Up @@ -4186,7 +4186,7 @@ Demuxer

``--prefetch-playlist=<yes|no>``
Prefetch next playlist entry while playback of the current entry is ending
(default: no).
(default: yes).

This does not prefill the cache with the video data of the next URL.
Prefetching video data is supported only for the current playlist entry,
Expand All @@ -4197,16 +4197,10 @@ Demuxer
This does **not** work with URLs resolved by the ``youtube-dl`` wrapper,
and it won't.

This can give subtly wrong results if per-file options are used, or if
options are changed in the time window between prefetching start and next
file played.

This can occasionally make wrong prefetching decisions. For example, it
can't predict whether you go backwards in the playlist, and assumes you
won't edit the playlist.

Highly experimental.

``--force-seekable=<yes|no>``
If the player thinks that the media is not seekable (e.g. playing from a
pipe, or it's an http stream with a server that doesn't support range
Expand Down
1 change: 1 addition & 0 deletions options/options.c
Original file line number Diff line number Diff line change
Expand Up @@ -996,6 +996,7 @@ static const struct MPOpts mp_default_opts = {
.demuxer_thread = true,
.demux_termination_timeout = 0.1,
.hls_bitrate = INT_MAX,
.prefetch_open = true,
.cache_pause = true,
.cache_pause_wait = 1.0,
.ab_loop = {MP_NOPTS_VALUE, MP_NOPTS_VALUE},
Expand Down