TSL: Add error handling for invalid shader code in FunctionNode #32287
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: None
Description
This PR adds a missing error check inside
FunctionNode.getNodeFunction().When
builder.parser.parseFunction()fails to parse the WGSL/GLSL shaderfunction, it returns
undefined. This leads to unclear runtime errors laterin the node-building pipeline (e.g., accessing
.inputs,.type,.nameonan undefined object).
By validating the parser result immediately and throwing a clear error
message, developers receive instant feedback about invalid shader code, making
TSL debugging significantly easier.
What this PR changes