Make connector cache more robust#1122
Merged
mrh0 merged 1 commit intomrh0:1.21.1from Mar 8, 2026
Merged
Conversation
Author
|
To give some more detail, the previous code was likely to throw NPEs if the BlockCapabilityCache was not created in the first tick. It also included relics from old LazyOptional caching, which are now handled by BlockCapabilityCache, like chunk loading, block replacement and capability invalidation in general |
mrh0
approved these changes
Mar 8, 2026
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Please review and complete all items before submitting your pull request:
MIT License Confirmation
Description
This should fix some issues with the external cache being null (see this discord mesage)