Skip to content

Make connector cache more robust#1122

Merged
mrh0 merged 1 commit intomrh0:1.21.1from
skippyall:connector-cache
Mar 8, 2026
Merged

Make connector cache more robust#1122
mrh0 merged 1 commit intomrh0:1.21.1from
skippyall:connector-cache

Conversation

@skippyall
Copy link
Copy Markdown

Pull Request Checklist

Please review and complete all items before submitting your pull request:

  • I have thoroughly tested the changes and verified they work as expected.
  • The code follows the coding standards and best practices of the project.
  • I have reviewed the changes for potential security or performance issues.

MIT License Confirmation

  • I confirm that all code included in this PR is compatible with the MIT License.
  • I understand and accept that, by submitting this pull request, all contributions are permanently licensed under the MIT License, and I waive any rights to revoke or change the license in the future.

Description

This should fix some issues with the external cache being null (see this discord mesage)

@skippyall
Copy link
Copy Markdown
Author

To give some more detail, the previous code was likely to throw NPEs if the BlockCapabilityCache was not created in the first tick. It also included relics from old LazyOptional caching, which are now handled by BlockCapabilityCache, like chunk loading, block replacement and capability invalidation in general

@mrh0 mrh0 merged commit 50b7bbb into mrh0:1.21.1 Mar 8, 2026
1 check passed
@mrh0
Copy link
Copy Markdown
Owner

mrh0 commented Mar 8, 2026

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants