Skip to content

[1.21.1] Implement ignitable fluids#1130

Open
tmvkrpxl0 wants to merge 11 commits intomrh0:1.21.1from
tmvkrpxl0:1.21.1-ignites
Open

[1.21.1] Implement ignitable fluids#1130
tmvkrpxl0 wants to merge 11 commits intomrh0:1.21.1from
tmvkrpxl0:1.21.1-ignites

Conversation

@tmvkrpxl0
Copy link
Copy Markdown

Pull Request Checklist

Please review and complete all items before submitting your pull request:

  • I have thoroughly tested the changes and verified they work as expected.
  • The code follows the coding standards and best practices of the project.
  • I have reviewed the changes for potential security or performance issues.

MIT License Confirmation

  • I confirm that all code included in this PR is compatible with the MIT License.
  • I understand and accept that, by submitting this pull request, all contributions are permanently licensed under the MIT License, and I waive any rights to revoke or change the license in the future.

Description

Implements burning down flammable fluids. I created new tag "c:ignites" because tag "c:flammable" includes lava as well.
but this is intended for fluids that catches fire like oil. and last time I checked lava does not burn down from fire.

This PR contains bunch of other changes as well. It's mostly because I re-generated data. I implemented data generator for "c:ignites" tag and included generated output as well.
While I was adding translation for "c:ignites" I discovered translation keys in ko_kr.json were slightly different to en_us.json. I'm not sure if I can see those in game but it was simple fix I decided to include fix for these as well.
I only added translation entries for English and Korean because I only speak these 2.
I think this feature should be explained in ponder in the future but this PR does not contain additional ponder entries.

Related Issues

This branch is based on my previous PR #1129 and contains fix for girder model.
Although I believe fix should be review separately, it's small enough change that can be merged together in this PR.

@tmvkrpxl0 tmvkrpxl0 changed the title 1.21.1 ignites [1.21.1] Implement ignitable fluids Apr 18, 2026
@tmvkrpxl0
Copy link
Copy Markdown
Author

tmvkrpxl0 commented Apr 18, 2026

Demonstration video: https://youtu.be/4s7y_9ZC4Os

Notes:
Oil can't normally replace fire unlike water, except when oil flows down into fire. Then fire is placed in north/south/west/east direction if it's empty.
Fire spreads faster when it rains, like how it's bad idea to pour water into grease fire.
There is 3rd black liquid with "c:ignites" tag in the video. It was for testing purpose and it is not included in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant