Open
Conversation
Author
|
Demonstration video: https://youtu.be/4s7y_9ZC4Os Notes: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Please review and complete all items before submitting your pull request:
MIT License Confirmation
Description
Implements burning down flammable fluids. I created new tag "c:ignites" because tag "c:flammable" includes lava as well.
but this is intended for fluids that catches fire like oil. and last time I checked lava does not burn down from fire.
This PR contains bunch of other changes as well. It's mostly because I re-generated data. I implemented data generator for "c:ignites" tag and included generated output as well.
While I was adding translation for "c:ignites" I discovered translation keys in ko_kr.json were slightly different to en_us.json. I'm not sure if I can see those in game but it was simple fix I decided to include fix for these as well.
I only added translation entries for English and Korean because I only speak these 2.
I think this feature should be explained in ponder in the future but this PR does not contain additional ponder entries.
Related Issues
This branch is based on my previous PR #1129 and contains fix for girder model.
Although I believe fix should be review separately, it's small enough change that can be merged together in this PR.