Skip to content

Commit

Permalink
fix some tests
Browse files Browse the repository at this point in the history
  • Loading branch information
mroeschke committed Dec 29, 2023
1 parent 54f6bce commit 0511ebe
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion pandas/tests/arrays/string_/test_string_arrow.py
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ def test_setitem_invalid_indexer_raises():
with tm.external_error_raised(IndexError):
arr[[True, True, False]] = "foo"

with tm.external_error_raised(IndexError):
with tm.external_error_raised(ValueError):
arr[[0, 1]] = ["foo", "bar", "baz"]


Expand Down
3 changes: 2 additions & 1 deletion pandas/tests/extension/base/setitem.py
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,8 @@ def test_setitem_integer_array(self, data, idx, box_in_series):
[0, 1, 2, pd.NA], True, marks=pytest.mark.xfail(reason="GH-31948")
),
(pd.array([0, 1, 2, pd.NA], dtype="Int64"), False),
(pd.array([0, 1, 2, pd.NA], dtype="Int64"), True),
# TODO: change False to True?
(pd.array([0, 1, 2, pd.NA], dtype="Int64"), False), # noqa: PT014
],
ids=["list-False", "list-True", "integer-array-False", "integer-array-True"],
)
Expand Down

0 comments on commit 0511ebe

Please sign in to comment.