Skip to content

Conversation

@BigtoC
Copy link

@BigtoC BigtoC commented Jun 26, 2025

No description provided.

@BigtoC
Copy link
Author

BigtoC commented Jul 7, 2025

@mrtnetwork Could you review this PR? 🙏

@mrtnetwork
Copy link
Owner

@mrtnetwork Could you review this PR? 🙏

Hi! If you want to add support for Ethereum address conversion, you should define them in the eth_addr file, along with corresponding classes like EthBech32Encoder and EthBech32Decoder.

Also, make sure to validate everything before performing conversions. For example, check if the input is a valid Ethereum address before encoding, or if it's a valid Bech32-encoded Ethereum address before decoding.

@BigtoC
Copy link
Author

BigtoC commented Jul 7, 2025

@mrtnetwork Could you review this PR? 🙏

Hi! If you want to add support for Ethereum address conversion, you should define them in the eth_addr file, along with corresponding classes like EthBech32Encoder and EthBech32Decoder.

Also, make sure to validate everything before performing conversions. For example, check if the input is a valid Ethereum address before encoding, or if it's a valid Bech32-encoded Ethereum address before decoding.

Thanks for reviewing! I've pushed the updated codes 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants