Skip to content

Add Data & Analytics Division#161

Open
aalhadxx wants to merge 1 commit intomsitarzewski:mainfrom
aalhadxx:add-data-analytics-division
Open

Add Data & Analytics Division#161
aalhadxx wants to merge 1 commit intomsitarzewski:mainfrom
aalhadxx:add-data-analytics-division

Conversation

@aalhadxx
Copy link
Copy Markdown

@aalhadxx aalhadxx commented Mar 12, 2026

Introduces 5 new specialized agents covering the full data & analytics workflow:

  • Data Analyst - SQL analysis, dashboards, metric storytelling
  • Data Scientist - ML models, A/B testing, statistical analysis
  • Data Platform Engineer - Airflow, dbt, production data pipelines
  • Analytics Engineer - dbt transformation, semantic layer
  • Business Intelligence Developer - Tableau, Power BI, dashboards

Each agent includes production-ready code examples, detailed workflows, and specific success metrics.

@msitarzewski
Copy link
Copy Markdown
Owner

Love this — I actually proposed a Data & Analytics division yesterday, so great minds! 🎉

The PR has merge conflicts on README.md (agent count and table have changed since your branch). Could you rebase against main and resolve?

Also, when you rebase, please update the agent count to 147 (we've merged several PRs since) and note that we'll also need data-analytics added to:

  • AGENT_DIRS in scripts/convert.sh
  • The directory loops in scripts/install.sh (install_claude_code() and install_copilot())
  • .github/workflows/lint-agents.yml trigger paths

If you'd rather just handle the rebase and I'll take care of the script updates, that works too. Thanks!

New agents:
- Data Analyst: SQL analysis, dashboards, metric storytelling
- Data Scientist: ML models, A/B testing, statistical analysis
- Data Platform Engineer: Airflow, dbt, data pipelines
- Analytics Engineer: dbt transformation, semantic layer
- Business Intelligence Developer: Tableau, Power BI, dashboards

Updates README with new division section and agent count (120->125).

Made-with: Cursor
@aalhadxx aalhadxx force-pushed the add-data-analytics-division branch from 01296e1 to edb1e7d Compare March 12, 2026 15:40
@aalhadxx
Copy link
Copy Markdown
Author

Done. Rebased on main, resolved the README conflict, and set the agent count to 147. Also added data-analytics to scripts/convert.sh, both directory loops in scripts/install.sh, and the lint workflow trigger paths.

@msitarzewski
Copy link
Copy Markdown
Owner

Sorry about this — we just merged a few PRs (#181, #182, #184) that touched README.md, so you've got conflicts again. 😬

Could you rebase one more time against main? The agent count will need updating too (we're at 149 now after the latest merges). Apologies for the churn — this one's getting merged as soon as it's clean.

@mhc222
Copy link
Copy Markdown

mhc222 commented Mar 30, 2026

Code Review

All 5 agent files have the correct 9-section structure with exact emoji + "Your" phrasing headers. convert.sh (AGENT_DIRS), install.sh (hardcoded dir loops for claude-code and copilot), and .github/workflows/lint-agents.yml are all updated to include data-analytics.


Critical: scripts/lint-agents.sh not updated (confidence: 100)

CONTRIBUTING.md requires that new agent directories be added to AGENT_DIRS in convert.sh, install.sh, lint-agents.sh, and .github/workflows/lint.yml. This PR updates three of the four locations but leaves scripts/lint-agents.sh unchanged. Running lint-agents.sh locally after this merge will silently skip all five new data-analytics/ agents.

Please add data-analytics to the AGENT_DIRS array (or equivalent path list) in scripts/lint-agents.sh.

@msitarzewski
Copy link
Copy Markdown
Owner

Hey @aalhadxx — the Data & Analytics Division is comprehensive and well-structured! Five agents covering the full data function (Analyst, Scientist, Platform Engineer, Analytics Engineer, BI Developer).

Same situation as #238: this PR modifies scripts/install.sh, scripts/convert.sh, and .github/workflows/lint-agents.yml to add the data-analytics/ directory. These files have changed substantially since this PR was opened and will conflict.

Could you rebase against current main? The AGENT_DIRS arrays are now sorted alphabetically — just add data-analytics in the right position. Once rebased, I'll review and merge.

Thanks for your patience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants