Skip to content

Add Cybersecurity Division with 5 specialized agents#223

Open
anonym88-ai wants to merge 2 commits intomsitarzewski:mainfrom
anonym88-ai:feat/cybersecurity-division
Open

Add Cybersecurity Division with 5 specialized agents#223
anonym88-ai wants to merge 2 commits intomsitarzewski:mainfrom
anonym88-ai:feat/cybersecurity-division

Conversation

@anonym88-ai
Copy link
Copy Markdown

Agent Information

Category: cybersecurity (new division)
Agents: Penetration Tester, Incident Responder, Cloud Security Architect, Threat Intelligence Analyst, Application Security Engineer

Motivation

The repo has 144+ agents across 14 categories but zero dedicated cybersecurity specialists — a major gap given how critical security is. This PR adds a complete Cybersecurity Division with 5 deeply specialized agents covering both offensive (red team, pentesting) and defensive (IR, threat intel, cloud security, AppSec) disciplines.

Each agent includes:

  • Production-quality code examples (Bash, Python, TypeScript, Terraform, YARA, Sigma)
  • Distinct personality and communication style
  • Measurable success metrics with specific numbers
  • Step-by-step battle-tested workflows

Testing

  • All agents tested in Claude Code sessions for realistic security scenarios
  • Code examples validated for correctness (Python imports, Sigma syntax, YARA rules, Terraform HCL)
  • Format verified against existing agents (blockchain-security-auditor, academic division)

Checklist

  • Follows agent template structure
  • Includes personality and voice
  • Has concrete code/template examples
  • Defines success metrics
  • Includes step-by-step workflow
  • Proofread and formatted correctly
  • Tested in real scenarios
  • convert.sh and install.sh updated
  • README.md and CONTRIBUTING.md updated

@mhc222
Copy link
Copy Markdown

mhc222 commented Mar 30, 2026

Code Review

Issue 1 — New cybersecurity/ directory is not registered in lint-agents.sh or the CI workflow [confidence: 100]

PR #223 introduces a new top-level cybersecurity/ directory with 5 agent files and correctly updates scripts/convert.sh and scripts/install.sh to include it. However, two tooling files are not updated:

  • scripts/lint-agents.shAGENT_DIRS does not list cybersecurity
  • .github/workflows/lint-agents.yml — does not include cybersecurity/** in trigger paths or the git diff glob

As a result, the 5 cybersecurity agents will never be linted locally or in CI. This is the same pattern that affected academic/, sales/, devrel/, and security/ in other PRs.

Fix: Add cybersecurity to AGENT_DIRS in scripts/lint-agents.sh and add cybersecurity/** to both the paths: trigger and the git diff glob in .github/workflows/lint-agents.yml.

What's good

All 5 agent files use the correct 9 required section headers with exact emoji and "Your" phrasing — this is the strongest content submission reviewed so far for section header compliance. The agents contain production-quality code examples (TypeScript, Python, Bash, YARA, Sigma, Terraform HCL) and well-defined success metrics. The convert.sh and install.sh updates are complete and correctly parallel the Qwen/Kiro patterns. CONTRIBUTING.md and README.md are updated appropriately. The single blocker is the lint registration.

anonym88-ai and others added 2 commits March 30, 2026 21:04
New division filling a major gap — the repo had 144+ agents across 14
categories but zero dedicated cybersecurity specialists.

Agents:
- Penetration Tester: red team ops, AD attacks, cloud/web pentesting
- Incident Responder: digital forensics, breach investigation, crisis coordination
- Cloud Security Architect: zero trust, IAM, IaC security, multi-cloud defense
- Threat Intelligence Analyst: MITRE ATT&CK, YARA/Sigma rules, adversary tracking
- Application Security Engineer: threat modeling, secure code review, SAST/DAST

Each agent includes production-quality code examples (Bash, Python,
TypeScript, Terraform, Solidity, YARA, Sigma), distinct personality,
measurable success metrics, and step-by-step workflows.

Also updates convert.sh, install.sh, README.md, and CONTRIBUTING.md
to integrate the new division.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add cybersecurity to AGENT_DIRS in lint-agents.sh and to the
CI workflow trigger paths and git diff glob so the 5 new agents
are linted locally and in CI.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@anonym88-ai anonym88-ai force-pushed the feat/cybersecurity-division branch from e9f6aef to bbf4b44 Compare March 30, 2026 19:06
@anonym88-ai
Copy link
Copy Markdown
Author

Thanks for the thorough review @mhc222!

Fixed the lint registration blocker, cybersecurity is now added to both scripts/lint-agents.sh (AGENT_DIRS) and .github/workflows/lint-agents.yml (trigger paths + git diff glob). See commit bbf4b44.

Branch has been rebased onto latest main, no conflicts. Ready for re-review.

@msitarzewski
Copy link
Copy Markdown
Owner

Hey @anonym88-ai — the Cybersecurity Division is comprehensive and well-structured! Five strong agents covering the full security function.

Before we can merge, we need to align on division naming with PR #326 (which proposes a security/ division with a Senior SecOps Engineer). Both PRs modify the same infrastructure files and propose different directory names. There's also overlap with PR #383's standalone Penetration Tester.

A Discussion has been created to resolve this: #438

Please weigh in there! Once the community aligns, we'll coordinate the merge. Thanks for your patience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants