Skip to content

Add Pricing Analyst agent - Strategy#312

Open
Shiven0504 wants to merge 4 commits intomsitarzewski:mainfrom
Shiven0504:add/pricing-analyst-agent
Open

Add Pricing Analyst agent - Strategy#312
Shiven0504 wants to merge 4 commits intomsitarzewski:mainfrom
Shiven0504:add/pricing-analyst-agent

Conversation

@Shiven0504
Copy link
Copy Markdown
Contributor

@Shiven0504 Shiven0504 commented Mar 21, 2026

Summary

  • I've added a new Pricing Analyst agent in the strategy category
  • It covers cost structure analysis, market/competitor intelligence, value-based pricing, and margin optimization
  • Also includes pricing models comparison, deliverable templates (pricing strategy doc, discount governance), and structured workflow

Closes #307

Test plan

  • Verify frontmatter fields (name, description, color, emoji, vibe, tools) are valid
  • Run convert.sh to confirm agent converts correctly to all integration formats
  • Review agent content for completeness against issue requirements

@msitarzewski
Copy link
Copy Markdown
Owner

Hey @Shiven0504 — thanks for this! The Pricing Analyst is a good addition.

One issue: it's filed under strategy/ which isn't an agent division directory. This should live in specialized/ (e.g., specialized/specialized-pricing-analyst.md). Could you move it there?

Also tagging @MeghanBao from issue #307 (pricing manager request) — does this cover what you had in mind?

@Shiven0504
Copy link
Copy Markdown
Contributor Author

Very well, I've moved it to the specialized/ directory. Let me know if anything else needs a tweak!

@mhc222
Copy link
Copy Markdown

mhc222 commented Mar 30, 2026

Code Review

PR: Add Pricing Analyst agent - Strategy

The agent content is strong — the four-pillar pricing framework, model comparison table, deliverable templates, and detailed workflow are well-constructed and genuinely useful. The agent has a clear personality and concrete, measurable success metrics. That's good work.

However, the agent file does not conform to the required section structure defined in CONTRIBUTING.md and used by the rest of the codebase.


Critical — Section headers do not match the required template

CONTRIBUTING.md specifies 9 required sections with exact headers (emoji prefix + "Your" phrasing). The convert.sh script uses these section headers to split agents into tool-specific formats (Persona vs Operations). Malformed headers will cause incorrect or broken conversions.

Missing or incorrect headers:

Required Actual
## 🧠 Your Identity & Memory ## Your Identity (no emoji, wrong title)
## 🎯 Your Core Mission ## Your Core Mission (no emoji)
## 🚨 Critical Rules You Must Follow ## Critical Rules You Must Follow (no emoji)
## 📋 Your Technical Deliverables ## Technical Deliverables (no emoji, missing "Your")
## 🔄 Your Workflow Process ## Your Workflow Process (no emoji)
## 💭 Your Communication Style MISSING entirely
## 🔄 Learning & Memory ## Learning & Memory (no emoji, missing "Your")
## 🎯 Your Success Metrics ## Success Metrics (no emoji, missing "Your")
## 🚀 Advanced Capabilities MISSING entirely

Additionally, the file inserts non-standard sections (## The Pricing Analysis Framework, ## Pricing Models & When to Use Them) between the frontmatter and the required sections. Custom sections are fine to add, but the 9 required sections must all be present with exact headers.

Recommended fix: Rename each header to match the required format exactly, add the two missing sections (## 💭 Your Communication Style and ## 🚀 Advanced Capabilities), and fold the custom framework/model sections into the appropriate required sections (e.g., framework content fits naturally under ## 📋 Your Technical Deliverables or ## 🚀 Advanced Capabilities).


The pricing strategy content itself is high quality and this agent fills a real gap. With the header corrections applied this would be ready to merge.

Updated the Pricing Analyst documentation to enhance clarity and structure, including new sections on core mission, critical rules, communication style, and advanced capabilities.
@Shiven0504
Copy link
Copy Markdown
Contributor Author

i've updated the content as per the required structure, including the header corrections 👍

@msitarzewski
Copy link
Copy Markdown
Owner

Hey @Shiven0504 — thanks for iterating on this! The pricing strategy content is strong. However, the section headers still don't match the CONTRIBUTING.md template — the emojis were changed but to the wrong ones.

Current vs. required:

Required Your file
## 🎯 Your Core Mission ## 💎 Your Core Mission (wrong emoji)
## 🚨 Critical Rules You Must Follow ## ⚠️ Critical Rules You Must Follow (wrong emoji)
## 📋 Your Technical Deliverables ## 📦 Your Technical Deliverables (wrong emoji)
## 💭 Your Communication Style ## 💬 Your Communication Style (wrong emoji)
## 🔄 Learning & Memory ## 📚 Learning & Memory (wrong emoji)
## 🎯 Your Success Metrics ## 📊 Your Success Metrics (wrong emoji)

The emojis need to match exactly — convert.sh uses these section headers to split agents into tool-specific formats. Check any recently merged agent (e.g., engineering/engineering-minimal-change-engineer.md) for the exact format.

Quick fix — just swap the 6 emojis above and this is good to go!

@Shiven0504
Copy link
Copy Markdown
Contributor Author

Updated the 6 emojis to match the exact template 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add an agent: pricing manager

4 participants