fix: add missing divisions to lint script and CI workflow#373
Closed
kienbui1995 wants to merge 1 commit intomsitarzewski:mainfrom
Closed
fix: add missing divisions to lint script and CI workflow#373kienbui1995 wants to merge 1 commit intomsitarzewski:mainfrom
kienbui1995 wants to merge 1 commit intomsitarzewski:mainfrom
Conversation
Add academic/ and sales/ to lint-agents.sh AGENT_DIRS and academic/ and strategy/ to CI workflow paths trigger and git diff filter. Note: strategy/ is excluded from lint-agents.sh because it contains playbooks and docs, not agent .md files with frontmatter. Fixes msitarzewski#242
Owner
|
Thanks @kienbui1995! Good catch on the missing divisions. We appreciate the thoughtful note about excluding We've merged #253 (comprehensive directory sync across all scripts) and #333 (lint hardening + CI expansion) which together cover the changes here. Closing as superseded — thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds missing division directories to
lint-agents.shand.github/workflows/lint-agents.ymlso all agent files are linted and CI-triggered.Fixes #242
Changes
scripts/lint-agents.shacademic/andsales/toAGENT_DIRS.github/workflows/lint-agents.ymlacademic/andstrategy/topathstrigger andgit difffilterNote:
strategy/is intentionally excluded fromlint-agents.shbecause it contains playbooks and docs (no frontmatter), not agent.mdfiles. It is included in CI paths trigger so workflow changes are still detected.Before / After
Relation to PR #333
PR #333 partially addresses this by adding
academic/to CI. This PR completes the fix by also addingsales/to lint andstrategy/to CI.