refact(api): Adding missing input validations #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 438
💛 - Coveralls |
oakbani
requested changes
Sep 28, 2018
lib/optimizely/helpers/validator.rb
Outdated
| if logger_valid?(logger) && level | ||
| logger.log(level, "#{Optimizely::Helpers::Constants::INPUT_VARIABLES[key.to_s.upcase]} is invalid") | ||
| is_valid = false unless value.is_a?(String) | ||
| unless key.to_s.upcase == Helpers::Constants::INPUT_VARIABLES.key('User ID') |
There was a problem hiding this comment.
This is not the right way. The method should only do it's own task. It should not know if the incoming thing is a user ID or not. You can keep this method as it is. And for user ids, check string right at the place
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.