Skip to content

upgrade to new geoip api #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 17, 2022
Merged

upgrade to new geoip api #9

merged 1 commit into from
Jan 17, 2022

Conversation

BuckarooBanzay
Copy link
Member

Switches to the new geoip api introduced here: mt-mods/geoip#7

@BuckarooBanzay BuckarooBanzay added the enhancement New feature or request label Jan 12, 2022
@BuckarooBanzay BuckarooBanzay requested a review from S-S-X January 12, 2022 12:31
S-S-X
S-S-X approved these changes Jan 12, 2022
View reviewed changes
Copy link
Member

@S-S-X S-S-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably better to fix with this now than waiting for my changes, I could push my stuff to some branch anyway to increase visibility.

@S-S-X
Copy link
Member

S-S-X commented Jan 12, 2022 •
edited
Loading

FYI https://github.com/mt-mods/beowulf/tree/ac-ban WIP stuff and requires another geoip update for some caching and other stuff (forgot to push that, added #10).
And related geoip mod caching layer + prejoin hooks: https://github.com/mt-mods/geoip/tree/geoip-cache (mt-mods/geoip#10)

@S-S-X
Copy link
Member

S-S-X commented Jan 12, 2022

Probably better to fix with this now than waiting for my changes, I could push my stuff to some branch anyway to increase visibility.

Well, unless it somehow works without crashing engine. In that case could optionally wait until I manage to finish updates / testing.
(I think it already works but I've not really tested well enough and it is fairly complicated)

@BuckarooBanzay BuckarooBanzay merged commit b908be5 into master Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@S-S-X S-S-X S-S-X approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BuckarooBanzay @S-S-X