Create meta boxes only for the taxonomies the post belongs to#6
Open
skoldin wants to merge 1 commit intomtekk:masterfrom
Open
Create meta boxes only for the taxonomies the post belongs to#6skoldin wants to merge 1 commit intomtekk:masterfrom
skoldin wants to merge 1 commit intomtekk:masterfrom
Conversation
Add check if the post is in taxonomy to create metaboxes only for the taxonomies the post belongs to Remove loop through $wp_post_types. It is not needed anymore. This saves hundreds of iterations.
mtekk
added a commit
that referenced
this pull request
Nov 5, 2015
Owner
|
I see the benefit (cleaner interface, sort of). However, there is a problem I see with this, it requires the edit page to be reloaded for the new metaboxes to be available (as a post changes membership in different taxonomies). If you're concerned about looping though too many things, there is a better way to improve this (see the commit 36ebded). Lastly, I would try to avoid relying on the $post global, especially if the action can pass it in for you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in function meta_boxes()
Add check if the post is in taxonomy to create metaboxes only for the
taxonomies the post belongs to
Remove loop through $wp_post_types. It is not needed anymore. This saves
hundreds of iterations.