Compat w/ trip ID cleanup regex (unused)

[mmathieum]

• Add trip ID cleanup regex + early route/stop ID cleanup parser#8

[gemini-code-assist]

Summary of Changes

Hello @mmathieum, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces foundational changes to support the cleanup and processing of GTFS Realtime trip IDs. While the title indicates the cleanup regex is currently 'unused', the changes lay the groundwork for future functionality by adding the necessary infrastructure, including new methods for loading and applying a trip ID cleanup regex, an extension function for trip ID hashing, and a new string resource. These updates ensure consistency with how route and stop IDs are handled and improve logging capabilities for unsupported trip entity selectors.

Highlights

• Trip ID Cleanup Regex Support: A new string resource and corresponding methods have been added to GTFSRealTimeProvider to manage a cleanup regex specifically for GTFS Realtime trip IDs, mirroring existing functionality for route and stop IDs.
• Trip ID Hashing Extension: A new Kotlin extension function getTripIdHash has been introduced to GtfsRealtime.EntitySelector, allowing for consistent processing and hashing of trip IDs, aligning with the established patterns for route and stop ID hashing.
• Enhanced Logging for Trip Entity Selectors: The parseTargetUUID method has been updated to include the cleaned or hashed trip ID in warning logs when an unsupported trip entity selector is encountered. This enhancement provides more detailed information for debugging purposes.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds support for a trip ID cleanup regex, which appears to be a preparatory change for a future feature. The changes are consistent with existing patterns for route and stop ID cleanup. I've identified a couple of thread-safety issues in the new lazy-initialization code in GTFSRealTimeProvider.java and have provided suggestions to address them by synchronizing the methods.