Store links > tries to open overlay (no working)

[mmathieum]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the application's ability to open external links, particularly those directed to the Google Play Store. By introducing support for Bundle extras in the link utility and strategically applying these extras when opening store pages, the changes aim to provide a more robust and consistent user experience, especially when trying to launch store content as an overlay.

Highlights

• LinkUtils Refactoring: The LinkUtils class has been refactored to introduce a new open method overload that accepts a Bundle for additional extras. Existing open methods now delegate to this new method, centralizing the logic for handling intent extras.
• StoreUtils Enhancements: The StoreUtils.viewAppPage method now attempts to open Google Play Store links with specific overlay and callerId extras first. This change aims to improve the behavior of opening store links, potentially resolving issues where they might not open correctly as an overlay.
• Code Style Improvements: Minor code style adjustments were made, such as simplifying single-line if statements by removing curly braces and updating a comment regarding Android permissions.

Changelog

• src/main/java/org/mtransit/android/commons/LinkUtils.java
  • Added android.os.Bundle import.
  • Introduced a new public static boolean open method overload that accepts a Bundle parameter for intent extras.
  • Refactored existing public static boolean open methods to call the new overload, passing null for the Bundle if not provided.
  • Simplified if statement syntax by removing curly braces for single-line conditions.
  • Updated a comment regarding the QUERY_ALL_PACKAGES permission.
• src/main/java/org/mtransit/android/commons/StoreUtils.java
  • Added android.os.Bundle import.
  • Renamed the TAG constant to LOG_TAG for consistency.
  • Modified the viewAppPage method to first attempt opening Google Play Store links using LinkUtils.open with overlay=true and callerId extras in a Bundle.
  • Ensured a fallback mechanism to the previous LinkUtils.open method using intentFlags if the initial attempt with extras is unsuccessful.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors LinkUtils to allow passing a Bundle of extras when opening a link, which is a good enhancement. However, the new implementation in StoreUtils introduces a critical compilation error by using an undeclared variable. I've provided a detailed comment with a code suggestion to fix this issue and also improve the readability of the new code.

[mmathieum]

/gemini review

[gemini-code-assist]

Code Review

This pull request refactors LinkUtils to allow passing a Bundle of extras when opening a link. This new functionality is then used in StoreUtils to try opening Google Play links in an overlay. The refactoring in LinkUtils is well done, centralizing logic and removing duplication. However, the implementation in StoreUtils introduces significant code repetition. I've added a comment with a suggestion to refactor the new code to be more concise and maintainable, a pattern that could be applied to the entire method.