Skip to content

Standardize logging constant naming to LOG_TAG across codebase #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mmathieum merged 5 commits into from
Mar 1, 2026
Merged

Standardize logging constant naming to LOG_TAG across codebase #77

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
279c5ea
Initial plan
Copilot Mar 1, 2026
62c890e
Rename TAG to LOG_TAG in all Java files
Copilot Mar 1, 2026
0a42513
Complete TAG to LOG_TAG renaming task
Copilot Mar 1, 2026
f2a3d84
Remove accidentally added gradle wrapper files
Copilot Mar 1, 2026
5a15650
Merge branch 'master' into copilot/rename-tag-constants-to-log-tag
mmathieum Mar 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions src/main/java/org/mtransit/android/commons/BundleUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,12 @@
@SuppressWarnings("unused")
public final class BundleUtils implements MTLog.Loggable {

private static final String TAG = BundleUtils.class.getSimpleName();
private static final String LOG_TAG = BundleUtils.class.getSimpleName();

@NonNull
@Override
public String getLogTag() {
return TAG;
return LOG_TAG;
}

@Nullable
Expand All @@ -28,7 +28,7 @@ public static Boolean getBoolean(@NonNull String key, @Nullable Bundle... bundle
}
}
}
MTLog.d(TAG, "Can't find the boolean value for key '%s' (returned null)", key);
MTLog.d(LOG_TAG, "Can't find the boolean value for key '%s' (returned null)", key);
return null;
}

Expand All @@ -41,7 +41,7 @@ public static Integer getInt(@NonNull String key, @Nullable Bundle... bundles) {
}
}
}
MTLog.d(TAG, "Can't find the int value for key '%s' (returned null)", key);
MTLog.d(LOG_TAG, "Can't find the int value for key '%s' (returned null)", key);
return null;
}

Expand All @@ -54,7 +54,7 @@ public static Long getLong(@NonNull String key, @Nullable Bundle... bundles) {
}
}
}
MTLog.d(TAG, "Can't find the long value for key '%s' (returned null)", key);
MTLog.d(LOG_TAG, "Can't find the long value for key '%s' (returned null)", key);
return null;
}

Expand All @@ -67,7 +67,7 @@ public static String getString(@NonNull String key, @Nullable Bundle... bundles)
}
}
}
MTLog.d(TAG, "Can't find the string value for key '%s' (returned null)", key);
MTLog.d(LOG_TAG, "Can't find the string value for key '%s' (returned null)", key);
return null;
}

Expand All @@ -80,7 +80,7 @@ public static Float getFloat(@NonNull String key, @Nullable Bundle... bundles) {
}
}
}
MTLog.d(TAG, "Can't find the float value for key '%s' (returned null)", key);
MTLog.d(LOG_TAG, "Can't find the float value for key '%s' (returned null)", key);
return null;
}

Expand All @@ -93,7 +93,7 @@ public static Double getDouble(@NonNull String key, @Nullable Bundle... bundles)
}
}
}
MTLog.d(TAG, "Can't find the double value for key '%s' (returned null)", key);
MTLog.d(LOG_TAG, "Can't find the double value for key '%s' (returned null)", key);
return null;
}

Expand All @@ -106,7 +106,7 @@ public static <T extends Parcelable> T getParcelable(@NonNull String key, @Nulla
}
}
}
MTLog.d(TAG, "Can't find the parcelable value for key '%s' (returned null)", key);
MTLog.d(LOG_TAG, "Can't find the parcelable value for key '%s' (returned null)", key);
return null;
}

Expand All @@ -119,7 +119,7 @@ public static String[] getStringArray(@NonNull String key, @Nullable Bundle... b
}
}
}
MTLog.d(TAG, "Can't find the string array value for key '%s' (returned null)", key);
MTLog.d(LOG_TAG, "Can't find the string array value for key '%s' (returned null)", key);
return null;
}

Expand All @@ -132,7 +132,7 @@ public static ArrayList<String> getStringArrayList(@NonNull String key, @Nullabl
}
}
}
MTLog.d(TAG, "Can't find the string array list value for key '%s' (returned null)", key);
MTLog.d(LOG_TAG, "Can't find the string array list value for key '%s' (returned null)", key);
return null;
}
}
6 changes: 3 additions & 3 deletions src/main/java/org/mtransit/android/commons/ThreadUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,12 @@

public final class ThreadUtils implements MTLog.Loggable {

private static final String TAG = ThreadUtils.class.getSimpleName();
private static final String LOG_TAG = ThreadUtils.class.getSimpleName();

@NonNull
@Override
public String getLogTag() {
return TAG;
return LOG_TAG;
}

/**
Expand All @@ -30,7 +30,7 @@ public static void sleepInMs(long sleepDurationInMs) {
try {
Thread.sleep(sleepDurationInMs);
} catch (InterruptedException e) {
MTLog.d(TAG, e, "Error while sleeping!");
MTLog.d(LOG_TAG, e, "Error while sleeping!");
}
}

Expand Down
4 changes: 2 additions & 2 deletions src/main/java/org/mtransit/android/commons/data/ServiceUpdate.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,12 @@

public class ServiceUpdate implements MTLog.Loggable {

private static final String TAG = ServiceUpdate.class.getSimpleName();
private static final String LOG_TAG = ServiceUpdate.class.getSimpleName();

@NonNull
@Override
public String getLogTag() {
return TAG;
return LOG_TAG;
}

public static final HigherSeverityFirstComparator HIGHER_SEVERITY_FIRST_COMPARATOR = new HigherSeverityFirstComparator();
Expand Down
8 changes: 4 additions & 4 deletions src/main/java/org/mtransit/android/commons/provider/JCDecauxBikeStationProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,12 +42,12 @@
@SuppressLint("Registered")
public class JCDecauxBikeStationProvider extends BikeStationProvider {

private static final String TAG = JCDecauxBikeStationProvider.class.getSimpleName();
private static final String LOG_TAG = JCDecauxBikeStationProvider.class.getSimpleName();

@NonNull
@Override
public String getLogTag() {
return TAG;
return LOG_TAG;
}

/**
Expand Down Expand Up @@ -229,10 +229,10 @@ private HashSet<DefaultPOI> loadDataFromWWW(int tried) {
}
return null;
} catch (SocketException se) {
MTLog.w(TAG, se, "No Internet Connection!");
MTLog.w(LOG_TAG, se, "No Internet Connection!");
return null;
} catch (Exception e) {
MTLog.e(TAG, e, "INTERNAL ERROR: Unknown Exception");
MTLog.e(LOG_TAG, e, "INTERNAL ERROR: Unknown Exception");
if (tried < MAX_RETRY) {
return loadDataFromWWW(++tried);
} else {
Expand Down
4 changes: 2 additions & 2 deletions src/main/java/org/mtransit/android/commons/provider/poi/POIProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -419,12 +419,12 @@ public static synchronized int insertDefaultPOIs(@NonNull POIProviderContract pr
@SuppressWarnings({"WeakerAccess", "unused"})
public static class POIDbHelper extends MTSQLiteOpenHelper {

private static final String TAG = POIDbHelper.class.getSimpleName();
private static final String LOG_TAG = POIDbHelper.class.getSimpleName();

@NonNull
@Override
public String getLogTag() {
return TAG;
return LOG_TAG;
}

/**
Expand Down
10 changes: 5 additions & 5 deletions ...va/org/mtransit/android/commons/provider/serviceupdate/ServiceUpdateProviderContract.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,12 +96,12 @@ class Columns {
@SuppressWarnings("WeakerAccess")
class Filter implements MTLog.Loggable {

private static final String TAG = ServiceUpdateProviderContract.class.getSimpleName() + ">" + Filter.class.getSimpleName();
private static final String LOG_TAG = ServiceUpdateProviderContract.class.getSimpleName() + ">" + Filter.class.getSimpleName();

@NonNull
@Override
public String getLogTag() {
return TAG;
return LOG_TAG;
}

private static final boolean CACHE_ONLY_DEFAULT = false;
Expand Down Expand Up @@ -331,7 +331,7 @@ public static Filter fromJSONString(@Nullable String jsonString) {
try {
return jsonString == null ? null : fromJSON(new JSONObject(jsonString));
} catch (JSONException jsone) {
MTLog.w(TAG, jsone, "Error while parsing JSON string '%s'", jsonString);
MTLog.w(LOG_TAG, jsone, "Error while parsing JSON string '%s'", jsonString);
return null;
}
}
Expand Down Expand Up @@ -374,7 +374,7 @@ public static Filter fromJSON(@NonNull JSONObject json) {
}
return serviceUpdateFilter;
} catch (JSONException jsone) {
MTLog.w(TAG, jsone, "Error while parsing JSON object '%s'", json);
MTLog.w(LOG_TAG, jsone, "Error while parsing JSON object '%s'", json);
return null;
}
}
Expand Down Expand Up @@ -420,7 +420,7 @@ public static JSONObject toJSON(@NonNull Filter serviceUpdateFilter) {
}
return json;
} catch (JSONException jsone) {
MTLog.w(TAG, jsone, "Error while making JSON object '%s'", serviceUpdateFilter);
MTLog.w(LOG_TAG, jsone, "Error while making JSON object '%s'", serviceUpdateFilter);
return null;
}
}
Expand Down