Add "last trip stop"

[mmathieum]

• Add "last trip stop" commons-android#83

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the map display by introducing a mechanism to visually differentiate 'last trip stops'. It modifies the icon selection process to consider specific POI characteristics and a feature flag, allowing these particular stops to be rendered with a distinct default icon instead of a directional arrow. This change improves clarity for users by highlighting critical points in a route.

Highlights

• Icon Definition Logic Update: The iconDefForRotation property in MTMapIconsProvider was refactored into a function getIconDefForRotation to allow passing a POI (Point Of Interest) object.
• Last Trip Stop Feature: New logic was introduced within getIconDefForRotation to identify and apply a default icon to 'last trip stops' if the F_EXPORT_DIRECTION_STOP_LAST feature flag is enabled and the POI is an isAlwaysLastTripStop.
• Map View Integration: Both MapViewModel (Kotlin) and MapViewController (Java) were updated to utilize the new getIconDefForRotation function, ensuring the POI object is passed for accurate icon selection.

Changelog

• app-android/src/main/java/org/mtransit/android/ui/map/MapViewModel.kt
  • Updated the call to getIconDefForRotation to pass the poi object for icon selection.
• app-android/src/main/java/org/mtransit/android/ui/view/MapViewController.java
  • Modified the map marker creation to pass the poim.poi object to getIconDefForRotation.
• app-android/src/main/java/org/mtransit/android/ui/view/map/MTMapIconsProvider.kt
  • Refactored iconDefForRotation into a function getIconDefForRotation that now accepts a POI object.
  • Added conditional logic to getIconDefForRotation to return a default icon for RouteDirectionStop POIs marked as isAlwaysLastTripStop when FeatureFlags.F_EXPORT_DIRECTION_STOP_LAST is enabled.
  • Imported POI, RouteDirectionStop, and FeatureFlags to support the new logic.

Activity

• No human activity (comments, reviews) has been recorded on this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a change to display a different map icon for the last stop of a trip. The implementation involves refactoring an extension property into a function to pass along POI information, and then using this information to decide which icon to show. The changes are logical and well-contained. I have one suggestion to improve code readability by simplifying nested conditional statements.