Skip to content

Proguard rule for Pangle SDK#15

Draft
mmathieum wants to merge 6 commits intomasterfrom
mm/14_add_pangleglobal
Draft

Proguard rule for Pangle SDK#15
mmathieum wants to merge 6 commits intomasterfrom
mm/14_add_pangleglobal

Conversation

@mmathieum
Copy link
Member

@mmathieum mmathieum commented Jun 17, 2025

@mmathieum mmathieum linked an issue Jun 17, 2025 that may be closed by this pull request
3 tasks
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @mmathieum, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a critical Proguard configuration to prevent runtime issues with the Pangle SDK in Android applications. By explicitly retaining the SDK's classes, it ensures that code shrinking and obfuscation do not inadvertently break the SDK's functionality.

Highlights

  • Proguard Configuration: Added a new Proguard rule to ensure the Pangle SDK's classes are preserved and not obfuscated or removed during the Android build process.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a Proguard keep rule for the Pangle SDK. The primary feedback focuses on the broadness of the added rule (-keep class com.bytedance.sdk.** { *; }). It's recommended to consult the Pangle SDK's official documentation to see if more specific rules are available, which could help optimize APK size and improve obfuscation. If the current broad rule is the official recommendation, adding a comment with a reference to the documentation would be beneficial for future code maintenance.

@mmathieum mmathieum self-assigned this Jun 17, 2025
montransit added a commit that referenced this pull request Nov 5, 2025
- commons-android: CI: build workflow improvements (#38)
- commons-java: CI: build workflow improvements (#7)
- parser: CI: build workflow improvements (#15)
montransit added a commit that referenced this pull request Jan 29, 2026
- commons-android: Change DEBUG constant to use environment variable (#52)
- commons-java: Change DEBUG constant to use environment variable (#15)
- parser: Change DEBUG constant to use environment variable (#29)
@mmathieum mmathieum added the paused ⏸️ paused work label Feb 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

paused ⏸️ paused work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Pangle ads SDK with mediation

1 participant