Schedule > clear head-sign instead of setting empty string by mmathieum · Pull Request #30 · mtransitapps/parser

mmathieum · 2026-01-29T19:14:55Z

No description provided.

This reverts commit 1e07710.

gemini-code-assist · 2026-01-29T19:15:12Z

Summary of Changes

Hello @mmathieum, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request reintroduces a previously reverted change aimed at refining the management of head-signs within the MSchedule object. The core purpose is to standardize how empty or null head-sign values are handled, ensuring they result in an explicit clearing of the head-sign rather than an assignment of an empty string. This change enhances data consistency and streamlines the underlying logic for head-sign operations.

Highlights

Head-sign Clearing Logic: Modified the MSchedule class to explicitly call clearHeadsign() when a new head-sign value is null or blank, ensuring that head-signs are cleared rather than being set to an empty string.
Code Refactoring: Simplified the conditional logic for setting the schedule head-sign in GenerateMObjectsTask.java by integrating the blank check directly into the else if statement.
Code Clean-up: Removed an unused MTLog import and added @Suppress("SimplifyBooleanWithConstants") annotations in MSchedule.kt for improved code hygiene.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request reverts a previous commit, primarily to restore the behavior of clearing head-signs in MSchedule when they are blank, instead of setting an empty string. This is a good change as it leads to a cleaner and more explicit state for schedules without a head-sign. The PR also includes some nice code quality improvements, such as removing an unused import, simplifying a conditional in GenerateMObjectsTask.java, and suppressing a linter warning for feature flags. The changes are well-justified and improve the codebase.

- parser: Schedule > clear head-sign instead of setting empty string mtransitapps/parser#30 - parser: Data Changed > compat with service IDs regex mtransitapps/parser#32

- commons: CI: add frequently used gh command with inputs in comments - parser: Remove unused trip IDs ints. mtransitapps/parser#31 - parser: Schedule > clear head-sign instead of setting empty string mtransitapps/parser#30 - parser: Data Changed > compat with service IDs regex mtransitapps/parser#32

- commons: CI: add frequently used gh command with inputs in comments - commons: Auto-trigger data sync when archive contains newer data than deployed mtransitapps/commons#537 - parser: Remove unused trip IDs ints. mtransitapps/parser#31 - parser: Schedule > clear head-sign instead of setting empty string mtransitapps/parser#30 - parser: Data Changed > compat with service IDs regex mtransitapps/parser#32

…parser': - commons: CI: add frequently used gh command with inputs in comments - commons: Auto-trigger data sync when archive contains newer data than deployed mtransitapps/commons#537 - commons: Enable `mt-sync-code-data` workflow on PRs with automatic skip of data download and app release mtransitapps/commons#539 - commons: app_reinstall_downgrade_debug_latest.sh ignore - commons: Remove `setGitBranch` from `code_setup.sh` and `set_app_release_required.sh` mtransitapps/commons#542 - commons: Add script for reinstalling debug APK with version downgrade support mtransitapps/commons#526 - commons: Fix PR reference in commits do not support markdown links, just use URL mtransitapps/commons#541 - commons: Convert PR references to full URLs in submodule sync commits mtransitapps/commons#533 - commons: Fix archive.sh: remove old archives when current archive exists mtransitapps/commons#536 - commons: prepare_only.sh (archive_selection.sh & unzip_gtfs.sh) > remove old gtfs next data if URL not availabla anymore - commons: Build(deps): Bump the maps group with 3 updates mtransitapps/commons#530 - commons: Build(deps): Bump com.google.ads.mediation:vungle from 7.6.3.0 to 7.6.3.1 in the ads group mtransitapps/commons#529 - commons: Build(deps): Bump com.google.devtools.ksp from 2.3.4 to 2.3.5 in the kotlin-ksp-compose group mtransitapps/commons#528 - commons: Compat w/ Winnipeg transit provider - commons: Compat w/ Greater Sudbury MyBus API - commons: Compat w/ Regina Transit provider - commons: Compat w/ QuebecRTC provider - commons: Compat w/ STM.info providers - commons: Compat w/ network security config - commons: Compat w/ GRT provider - commons: Compat w/ CaEdmontonProvider - commons: Compat w/ Strategic Mapping provider - commons: AndroidManifest.xml gen > EXPORT_VEHICLE_LOCATION_PROVIDER FF (OFF) - commons: AndroidManifest.xml gen > compat w/ NextBus #VehicleLocationProvider - commons-android: BUG > map marker icons are greens (more visible w/ low DPIs) mtransitapps/commons-android#53 - commons-android: cleanup - commons-android: Change DEBUG constant to use environment variable mtransitapps/commons-android#52 - commons-java: cleanup - commons-java: Change DEBUG constant to use environment variable mtransitapps/commons-java#15 - parser: Remove unused trip IDs ints. mtransitapps/parser#31 - parser: Schedule > clear head-sign instead of setting empty string mtransitapps/parser#30 - parser: Data Changed > compat with service IDs regex mtransitapps/parser#32 - parser: Reader > fix trip_ids file name - parser: Revert "MSchedule > clear head-sign instead of setting empty string" - parser: MSchedule > clear head-sign instead of setting empty string - parser: Current schedule > only look backward for single-day service if already present in current schedule... - parser: Change DEBUG constant to use environment variable mtransitapps/parser#29 - parser: Avoid data change > reading service dates > compat w/ flatten FF - parser: Export trip IDs [ints], service IDs, [schedule] strings FFs > delete old files if FF is ON->OFF - parser: Better clean mergedIds (+trip Ids)

- commons: CI: add frequently used gh command with inputs in comments - commons: Auto-trigger data sync when archive contains newer data than deployed mtransitapps/commons#537 - parser: fix compat with no last service calendar dates - parser: Remove unused trip IDs ints. mtransitapps/parser#31 - parser: Schedule > clear head-sign instead of setting empty string mtransitapps/parser#30 - parser: Data Changed > compat with service IDs regex mtransitapps/parser#32

Reapply "MSchedule > clear head-sign instead of setting empty string"

b309175

This reverts commit 1e07710.

mmathieum self-assigned this Jan 29, 2026

mmathieum changed the title ~~Reapply "MSchedule > clear head-sign instead of setting empty string"~~ Schedule > clear head-sign instead of setting empty string Jan 29, 2026

gemini-code-assist bot reviewed Jan 29, 2026

View reviewed changes

mmathieum added the data_change Triggers data changes label Jan 29, 2026

mmathieum marked this pull request as ready for review February 3, 2026 14:37

Merge branch 'master' into mm/mschedule_no_empty_string_headsigns

a9ebe6c

mmathieum merged commit 08b64d2 into master Feb 3, 2026
4 checks passed

mmathieum deleted the mm/mschedule_no_empty_string_headsigns branch February 3, 2026 19:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Schedule > clear head-sign instead of setting empty string#30

Schedule > clear head-sign instead of setting empty string#30
mmathieum merged 2 commits intomasterfrom
mm/mschedule_no_empty_string_headsigns

mmathieum commented Jan 29, 2026 •

edited

Loading

Uh oh!

gemini-code-assist bot commented Jan 29, 2026

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

mmathieum commented Jan 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist bot commented Jan 29, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

mmathieum commented Jan 29, 2026 •

edited

Loading