Generated XML file > ignore TypographyDashes

[mmathieum]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @mmathieum, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses minor code quality improvements by updating the XML generation logic to ignore TypographyDashes lint warnings, ensuring cleaner generated resource files. Additionally, it refines the codebase by removing an unnecessary noinspection comment, contributing to better maintainability.

Highlights

• XML Generation: The generated XML header now includes TypographyDashes in the tools:ignore attribute, preventing lint warnings related to typographic dashes in the generated resource files.
• Code Cleanup: A redundant //noinspection IfStatementWithIdenticalBranches comment was removed, streamlining the code without altering its behavior.

Changelog

• src/main/java/org/mtransit/parser/mt/MGenerator.java
  • Added TypographyDashes to the tools:ignore attribute in the RESOURCES_START constant.
  • Removed the IfStatementWithIdenticalBranches part from a //noinspection comment.

Activity

• No human activity has been recorded on this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request effectively addresses the TypographyDashes lint warning in the generated XML resource file by adding it to the tools:ignore attribute. Additionally, it cleans up a redundant //noinspection comment, which is a good practice. Both changes are clear and contribute to code quality and maintainability.

[Copilot]

Pull request overview

Updates the Android resources XML generated by MGenerator to suppress TypographyDashes lint warnings, and simplifies a local suppression comment.

Changes:

• Extend tools:ignore in generated <resources> to include TypographyDashes.
• Remove an unnecessary IfStatementWithIdenticalBranches inspection suppression.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.