Allow ignore invalid times by mmathieum · Pull Request #39 · mtransitapps/parser

mmathieum · 2026-02-24T20:05:44Z

No description provided.

gemini-code-assist · 2026-02-24T20:07:09Z

Summary of Changes

Hello @mmathieum, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the GTFS parsing process by adding functionality to gracefully handle invalid stop times. It introduces configuration options to allow ignoring these invalid times, which can be particularly useful for transit agencies with data quality issues. The changes prevent the parser from crashing due to invalid data, providing a more robust and flexible parsing solution.

Highlights

Invalid Stop Times Handling: This PR introduces a mechanism to allow ignoring invalid stop times based on configuration, preventing fatal errors during GTFS parsing.
Configuration Options: Added new configuration options in RouteConfig to control the behavior of ignoring invalid stop times, including a date until which invalid times should be ignored.
Code Modifications: Modified GAgencyTools and DefaultAgencyTools to support the new configuration and handle cases where stop times cannot be extracted.

Activity

The PR introduces a new feature to allow ignoring invalid stop times during GTFS parsing.
Configuration options were added to RouteConfig to control the behavior of ignoring invalid stop times.
Code modifications were made to GAgencyTools and DefaultAgencyTools to support the new configuration and handle cases where stop times cannot be extracted.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request introduces a feature to allow ignoring invalid stop times, which is a valuable improvement for handling imperfect GTFS data without crashing. The implementation is sound and consistently applied across the necessary files. I have provided a couple of suggestions to make some of the new Kotlin code more idiomatic and robust.

src/main/java/org/mtransit/parser/config/gtfs/data/RouteConfig.kt

src/main/java/org/mtransit/parser/gtfs/data/GStopTime.kt

…parser#39

…er': - commons: fix commit message - commons: Fix local code change not commited if no submodule change - commons: download.sh > print git status (debug) - commons: Fix condition for MT download data step - commons-android: GTFS RT Vehicle location > can target agency only #TransitWindsor mtransitapps/commons-android#70 - commons-java: Clean utils > LC UP strings > use ignored words - commons-java: Strings cleaner improvements - parser: Config > + `stop_code_prepend_if_missing`, `direction_types`, `direction_headsign_remove_route_[short_name/desc]` mtransitapps/parser#40 - parser: Allow ignore invalid times mtransitapps/parser#39 - parser: GTFS configs > + string/word UPPER CASE (&ignored words), trip excludes by head-sign & fix empty generated string resource mtransitapps/parser#38

…parser': - commons: fix commit message - commons: Fix local code change not commited if no submodule change - commons: download.sh > print git status (debug) - commons: Fix condition for MT download data step - commons-android: GTFS RT Vehicle location > can target agency only #TransitWindsor mtransitapps/commons-android#70 - commons-java: Clean utils > LC UP strings > use ignored words - commons-java: Strings cleaner improvements - parser: Config > + `stop_code_prepend_if_missing`, `direction_types`, `direction_headsign_remove_route_[short_name/desc]` mtransitapps/parser#40 - parser: Allow ignore invalid times mtransitapps/parser#39 - parser: GTFS configs > + string/word UPPER CASE (&ignored words), trip excludes by head-sign & fix empty generated string resource mtransitapps/parser#38

…er': - commons: fix commit message - commons: Fix local code change not commited if no submodule change - commons: download.sh > print git status (debug) - commons: Fix condition for MT download data step - commons-android: GTFS RT Vehicle location > can target agency only #TransitWindsor mtransitapps/commons-android#70 - commons-java: Clean utils > LC UP strings > use ignored words - commons-java: Strings cleaner improvements - parser: Config > + `stop_code_prepend_if_missing`, `direction_types`, `direction_headsign_remove_route_[short_name/desc]` mtransitapps/parser#40 - parser: Allow ignore invalid times mtransitapps/parser#39 - parser: GTFS configs > + string/word UPPER CASE (&ignored words), trip excludes by head-sign & fix empty generated string resource mtransitapps/parser#38

…parser': - commons: Build(deps): Bump the di group with 2 updates mtransitapps/commons#592 - commons: Build(deps): Bump hilt from 2.59.1 to 2.59.2 mtransitapps/commons#593 - commons: Build(deps): Bump com.google.maps.android:android-maps-utils from 4.0.0 to 4.1.0 in the maps group mtransitapps/commons#591 - commons: Build(deps): Bump actions/upload-artifact from 4 to 6 in /shared-overwrite/.github/workflows in the gh-actions group across 1 directory mtransitapps/commons#590 - commons: fix commit message - commons: Fix local code change not commited if no submodule change - commons: download.sh > print git status (debug) - commons: Fix condition for MT download data step - commons-android: Vehicle location report timestamp instant / countdown duration mtransitapps/commons-android#69 - commons-android: Update SSL cert mtransitapps/commons-android#74 - commons-android: CI > update SSL cert frequently mtransitapps/commons-android#71 - commons-android: Network security > add Mozilla CAs to increase compat w/ old Android versions - commons-android: NextBus/GTFS-RT > SSL issue > better logs and store last try to avoid consecutives failures - commons-android: Security provider > logs++ - commons-android: Security provider > logs++ - commons-android: GTFS RT Vehicle location > can target agency only #TransitWindsor mtransitapps/commons-android#70 - commons-java: Clean utils > LC UP strings > use ignored words - commons-java: Strings cleaner improvements - parser: Config > + `stop_code_prepend_if_missing`, `direction_types`, `direction_headsign_remove_route_[short_name/desc]` mtransitapps/parser#40 - parser: Allow ignore invalid times mtransitapps/parser#39 - parser: GTFS configs > + string/word UPPER CASE (&ignored words), trip excludes by head-sign & fix empty generated string resource mtransitapps/parser#38

…parser': - commons: Support for `agency_owner` file and improve `fr` files mtransitapps/commons#594 - commons: Build(deps): Bump the di group with 2 updates mtransitapps/commons#592 - commons: Build(deps): Bump hilt from 2.59.1 to 2.59.2 mtransitapps/commons#593 - commons: Build(deps): Bump com.google.maps.android:android-maps-utils from 4.0.0 to 4.1.0 in the maps group mtransitapps/commons#591 - commons: Build(deps): Bump actions/upload-artifact from 4 to 6 in /shared-overwrite/.github/workflows in the gh-actions group across 1 directory mtransitapps/commons#590 - commons: fix commit message - commons: Fix local code change not commited if no submodule change - commons: download.sh > print git status (debug) - commons: Fix condition for MT download data step - commons-android: Vehicle location report timestamp instant / countdown duration mtransitapps/commons-android#69 - commons-android: Update SSL cert mtransitapps/commons-android#74 - commons-android: CI > update SSL cert frequently mtransitapps/commons-android#71 - commons-android: Network security > add Mozilla CAs to increase compat w/ old Android versions - commons-android: NextBus/GTFS-RT > SSL issue > better logs and store last try to avoid consecutives failures - commons-android: Security provider > logs++ - commons-android: Security provider > logs++ - commons-android: GTFS RT Vehicle location > can target agency only #TransitWindsor mtransitapps/commons-android#70 - commons-java: Clean utils > LC UP strings > use ignored words - commons-java: Strings cleaner improvements - parser: JSON config > add `use_route_long_name_for_route_short_name` - parser: Route config > add `route_id_(previous|next)_char_configs`, `use_stop_id_hash_code` & `route_long_name_remove_route_id` mtransitapps/parser#41 - parser: Config > + `stop_code_prepend_if_missing`, `direction_types`, `direction_headsign_remove_route_[short_name/desc]` mtransitapps/parser#40 - parser: Allow ignore invalid times mtransitapps/parser#39 - parser: GTFS configs > + string/word UPPER CASE (&ignored words), trip excludes by head-sign & fix empty generated string resource mtransitapps/parser#38

…parser': - commons: Support for `agency_owner` file and improve `fr` files mtransitapps/commons#594 - commons: Build(deps): Bump the di group with 2 updates mtransitapps/commons#592 - commons: Build(deps): Bump hilt from 2.59.1 to 2.59.2 mtransitapps/commons#593 - commons: Build(deps): Bump com.google.maps.android:android-maps-utils from 4.0.0 to 4.1.0 in the maps group mtransitapps/commons#591 - commons: Build(deps): Bump actions/upload-artifact from 4 to 6 in /shared-overwrite/.github/workflows in the gh-actions group across 1 directory mtransitapps/commons#590 - commons: fix commit message - commons-android: Vehicle location report timestamp instant / countdown duration mtransitapps/commons-android#69 - commons-android: Update SSL cert mtransitapps/commons-android#74 - commons-android: CI > update SSL cert frequently mtransitapps/commons-android#71 - commons-android: Network security > add Mozilla CAs to increase compat w/ old Android versions - commons-android: NextBus/GTFS-RT > SSL issue > better logs and store last try to avoid consecutives failures - commons-android: Security provider > logs++ - commons-android: Security provider > logs++ - commons-android: GTFS RT Vehicle location > can target agency only #TransitWindsor mtransitapps/commons-android#70 - commons-java: Clean utils > LC UP strings > use ignored words - commons-java: Strings cleaner improvements - parser: JSON config > add `use_route_long_name_for_route_short_name` - parser: Route config > add `route_id_(previous|next)_char_configs`, `use_stop_id_hash_code` & `route_long_name_remove_route_id` mtransitapps/parser#41 - parser: Config > + `stop_code_prepend_if_missing`, `direction_types`, `direction_headsign_remove_route_[short_name/desc]` mtransitapps/parser#40 - parser: Allow ignore invalid times mtransitapps/parser#39 - parser: GTFS configs > + string/word UPPER CASE (&ignored words), trip excludes by head-sign & fix empty generated string resource mtransitapps/parser#38

…parser': - commons: Support for `agency_owner` file and improve `fr` files mtransitapps/commons#594 - commons: Build(deps): Bump the di group with 2 updates mtransitapps/commons#592 - commons: Build(deps): Bump hilt from 2.59.1 to 2.59.2 mtransitapps/commons#593 - commons: Build(deps): Bump com.google.maps.android:android-maps-utils from 4.0.0 to 4.1.0 in the maps group mtransitapps/commons#591 - commons: Build(deps): Bump actions/upload-artifact from 4 to 6 in /shared-overwrite/.github/workflows in the gh-actions group across 1 directory mtransitapps/commons#590 - commons: fix commit message - commons: Fix local code change not commited if no submodule change - commons: download.sh > print git status (debug) - commons: Fix condition for MT download data step - commons-android: Vehicle location report timestamp instant / countdown duration mtransitapps/commons-android#69 - commons-android: Update SSL cert mtransitapps/commons-android#74 - commons-android: CI > update SSL cert frequently mtransitapps/commons-android#71 - commons-android: Network security > add Mozilla CAs to increase compat w/ old Android versions - commons-android: NextBus/GTFS-RT > SSL issue > better logs and store last try to avoid consecutives failures - commons-android: Security provider > logs++ - commons-android: Security provider > logs++ - commons-android: GTFS RT Vehicle location > can target agency only #TransitWindsor mtransitapps/commons-android#70 - commons-java: Clean utils > LC UP strings > use ignored words - commons-java: Strings cleaner improvements - parser: JSON config > add `use_route_long_name_for_route_short_name` - parser: Route config > add `route_id_(previous|next)_char_configs`, `use_stop_id_hash_code` & `route_long_name_remove_route_id` mtransitapps/parser#41 - parser: Config > + `stop_code_prepend_if_missing`, `direction_types`, `direction_headsign_remove_route_[short_name/desc]` mtransitapps/parser#40 - parser: Allow ignore invalid times mtransitapps/parser#39 - parser: GTFS configs > + string/word UPPER CASE (&ignored words), trip excludes by head-sign & fix empty generated string resource mtransitapps/parser#38

…er': - commons: Update social media links in MTREADME.md.MT.sh - commons: Play cleanup - commons: Support for `agency_owner` file and improve `fr` files mtransitapps/commons#594 - commons: Build(deps): Bump the di group with 2 updates mtransitapps/commons#592 - commons: Build(deps): Bump hilt from 2.59.1 to 2.59.2 mtransitapps/commons#593 - commons: Build(deps): Bump com.google.maps.android:android-maps-utils from 4.0.0 to 4.1.0 in the maps group mtransitapps/commons#591 - commons: Build(deps): Bump actions/upload-artifact from 4 to 6 in /shared-overwrite/.github/workflows in the gh-actions group across 1 directory mtransitapps/commons#590 - commons: fix commit message - commons: Fix local code change not commited if no submodule change - commons: download.sh > print git status (debug) - commons: Fix condition for MT download data step - commons-android: Standardize logging constant naming to LOG_TAG across codebase mtransitapps/commons-android#77 - commons-android: Remove useless fasterxml proguard rules mtransitapps/commons-android#78 - commons-android: Store links > tries to open overlay (no working) mtransitapps/commons-android#76 - commons-android: News providers > re-enable for main app mtransitapps/commons-android#75 - commons-android: Vehicle location report timestamp instant / countdown duration mtransitapps/commons-android#69 - commons-android: Update SSL cert mtransitapps/commons-android#74 - commons-android: CI > update SSL cert frequently mtransitapps/commons-android#71 - commons-android: Network security > add Mozilla CAs to increase compat w/ old Android versions - commons-android: NextBus/GTFS-RT > SSL issue > better logs and store last try to avoid consecutives failures - commons-android: Security provider > logs++ - commons-android: Security provider > logs++ - commons-android: GTFS RT Vehicle location > can target agency only #TransitWindsor mtransitapps/commons-android#70 - commons-java: Clean utils > LC UP strings > use ignored words - commons-java: Strings cleaner improvements - parser: JSON config > add `use_route_long_name_for_route_short_name` - parser: Route config > add `route_id_(previous|next)_char_configs`, `use_stop_id_hash_code` & `route_long_name_remove_route_id` mtransitapps/parser#41 - parser: Config > + `stop_code_prepend_if_missing`, `direction_types`, `direction_headsign_remove_route_[short_name/desc]` mtransitapps/parser#40 - parser: Allow ignore invalid times mtransitapps/parser#39 - parser: GTFS configs > + string/word UPPER CASE (&ignored words), trip excludes by head-sign & fix empty generated string resource mtransitapps/parser#38

…er': - commons: Update social media links in MTREADME.md.MT.sh - commons: Play cleanup - commons: Support for `agency_owner` file and improve `fr` files mtransitapps/commons#594 - commons: Build(deps): Bump the di group with 2 updates mtransitapps/commons#592 - commons: Build(deps): Bump hilt from 2.59.1 to 2.59.2 mtransitapps/commons#593 - commons: Build(deps): Bump com.google.maps.android:android-maps-utils from 4.0.0 to 4.1.0 in the maps group mtransitapps/commons#591 - commons: Build(deps): Bump actions/upload-artifact from 4 to 6 in /shared-overwrite/.github/workflows in the gh-actions group across 1 directory mtransitapps/commons#590 - commons: fix commit message - commons: Fix local code change not commited if no submodule change - commons: download.sh > print git status (debug) - commons: Fix condition for MT download data step - commons-android: Standardize logging constant naming to LOG_TAG across codebase mtransitapps/commons-android#77 - commons-android: Remove useless fasterxml proguard rules mtransitapps/commons-android#78 - commons-android: Store links > tries to open overlay (no working) mtransitapps/commons-android#76 - commons-android: News providers > re-enable for main app mtransitapps/commons-android#75 - commons-android: Vehicle location report timestamp instant / countdown duration mtransitapps/commons-android#69 - commons-android: Update SSL cert mtransitapps/commons-android#74 - commons-android: CI > update SSL cert frequently mtransitapps/commons-android#71 - commons-android: Network security > add Mozilla CAs to increase compat w/ old Android versions - commons-android: NextBus/GTFS-RT > SSL issue > better logs and store last try to avoid consecutives failures - commons-android: Security provider > logs++ - commons-android: Security provider > logs++ - commons-android: GTFS RT Vehicle location > can target agency only #TransitWindsor mtransitapps/commons-android#70 - commons-java: Strings cleaner > remove Line/Station auto mtransitapps/commons-java#22 - commons-java: Clean utils > LC UP strings > use ignored words - commons-java: Strings cleaner improvements - parser: JSON configs > add `stop_name_cleaners`, `(exclude|keep)_routes` & compat w/ mtransitapps/commons-java#22 mtransitapps/parser#43 - parser: JSON config > add `use_route_long_name_for_route_short_name` - parser: Route config > add `route_id_(previous|next)_char_configs`, `use_stop_id_hash_code` & `route_long_name_remove_route_id` mtransitapps/parser#41 - parser: Config > + `stop_code_prepend_if_missing`, `direction_types`, `direction_headsign_remove_route_[short_name/desc]` mtransitapps/parser#40 - parser: Allow ignore invalid times mtransitapps/parser#39 - parser: GTFS configs > + string/word UPPER CASE (&ignored words), trip excludes by head-sign & fix empty generated string resource mtransitapps/parser#38

…parser': - commons: Update social media links in MTREADME.md.MT.sh - commons: Play cleanup - commons: Support for `agency_owner` file and improve `fr` files mtransitapps/commons#594 - commons: Build(deps): Bump the di group with 2 updates mtransitapps/commons#592 - commons: Build(deps): Bump hilt from 2.59.1 to 2.59.2 mtransitapps/commons#593 - commons: Build(deps): Bump com.google.maps.android:android-maps-utils from 4.0.0 to 4.1.0 in the maps group mtransitapps/commons#591 - commons: Build(deps): Bump actions/upload-artifact from 4 to 6 in /shared-overwrite/.github/workflows in the gh-actions group across 1 directory mtransitapps/commons#590 - commons: fix commit message - commons: Fix local code change not commited if no submodule change - commons: download.sh > print git status (debug) - commons: Fix condition for MT download data step - commons-android: Standardize logging constant naming to LOG_TAG across codebase mtransitapps/commons-android#77 - commons-android: Remove useless fasterxml proguard rules mtransitapps/commons-android#78 - commons-android: Store links > tries to open overlay (no working) mtransitapps/commons-android#76 - commons-android: News providers > re-enable for main app mtransitapps/commons-android#75 - commons-android: Vehicle location report timestamp instant / countdown duration mtransitapps/commons-android#69 - commons-android: Update SSL cert mtransitapps/commons-android#74 - commons-android: CI > update SSL cert frequently mtransitapps/commons-android#71 - commons-android: Network security > add Mozilla CAs to increase compat w/ old Android versions - commons-android: NextBus/GTFS-RT > SSL issue > better logs and store last try to avoid consecutives failures - commons-android: Security provider > logs++ - commons-android: Security provider > logs++ - commons-android: GTFS RT Vehicle location > can target agency only #TransitWindsor mtransitapps/commons-android#70 - commons-java: Strings cleaner > remove Line/Station auto mtransitapps/commons-java#22 - commons-java: Clean utils > LC UP strings > use ignored words - commons-java: Strings cleaner improvements - parser: JSON config > add `stop_headsign_remove_route_long_name_cleaner` - parser: JSON configs > add `extended_target_route_type_id` & `stop_time_excludes` mtransitapps/parser#44 - parser: JSON configs > add `stop_name_cleaners`, `(exclude|keep)_routes` & compat w/ mtransitapps/commons-java#22 mtransitapps/parser#43 - parser: JSON config > add `use_route_long_name_for_route_short_name` - parser: Route config > add `route_id_(previous|next)_char_configs`, `use_stop_id_hash_code` & `route_long_name_remove_route_id` mtransitapps/parser#41 - parser: Config > + `stop_code_prepend_if_missing`, `direction_types`, `direction_headsign_remove_route_[short_name/desc]` mtransitapps/parser#40 - parser: Allow ignore invalid times mtransitapps/parser#39 - parser: GTFS configs > + string/word UPPER CASE (&ignored words), trip excludes by head-sign & fix empty generated string resource mtransitapps/parser#38

Allow ignore invalid times

d7bcc93

mmathieum self-assigned this Feb 24, 2026

mmathieum mentioned this pull request Feb 24, 2026

Manually created GTFS zip file mtransitapps/ca-saskatoon-transit-bus-android#2

Merged

gemini-code-assist bot reviewed Feb 24, 2026

View reviewed changes

src/main/java/org/mtransit/parser/config/gtfs/data/RouteConfig.kt Outdated Show resolved Hide resolved

src/main/java/org/mtransit/parser/gtfs/data/GStopTime.kt Outdated Show resolved Hide resolved

PR comments

6130d6c

mmathieum marked this pull request as ready for review February 24, 2026 20:12

mmathieum merged commit c018bdb into master Feb 24, 2026
4 checks passed

mmathieum deleted the mm/allow_ignore_invalid_time branch February 24, 2026 20:16

montransit added a commit to mtransitapps/mtransit-for-android that referenced this pull request Feb 24, 2026

CI: Sync code from 'parser': Allow ignore invalid times mtransitapps/…

a3b1e22

…parser#39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow ignore invalid times#39

Allow ignore invalid times#39
mmathieum merged 2 commits intomasterfrom
mm/allow_ignore_invalid_time

mmathieum commented Feb 24, 2026

Uh oh!

gemini-code-assist bot commented Feb 24, 2026

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

mmathieum commented Feb 24, 2026

Uh oh!

gemini-code-assist bot commented Feb 24, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant