Cap raster resolution to GPU MAX_TEXTURE_SIZE#89
Merged
Conversation
At extreme zoom, Pixi text textures and filter render targets could exceed gl.MAX_TEXTURE_SIZE. The failed allocation rendered a black rect over the affected region, looking like a camera near-plane clipping through the canvas. Clamp the requested resolution against MAX_TEXTURE_SIZE so high-z items go soft instead of disappearing. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gl.MAX_TEXTURE_SIZE. The failed allocation composited a black/garbage rect over the affected region — visually like a near-plane camera clipping through high-z items, with lower layers (canvas surface, shapes) only visible where no text would have covered them.clampRasterResolution(requested, itemDim, maxTextureSize)inrasterCaps.ts(with cached GL probegetMaxTextureSize()).pixiText.resolution,ClampingBlurFilter.resolution, andDropShadowFilter.resolutionare clamped against the cap. Past the threshold, glyphs/filters go soft instead of disappearing.Math.min(2, …)cap with the same root cause in its comment ("clipping shows up as rectangular edges on filtered output") — left unchanged here, but the new helper would generalize it.Test plan
npm run preflight(lint, typecheck, unit, e2e) — all greenblurRadius > 0items at extreme zoom🤖 Generated with Claude Code