Skip to content

fix(agents): demote abandoned ACTIVE rows so agent-record can pass - #177

Closed
bakon11 wants to merge 1 commit into
mudler:mainfrom
bakon11:fix/audit-abandon-stale-active
Closed

fix(agents): demote abandoned ACTIVE rows so agent-record can pass#177
bakon11 wants to merge 1 commit into
mudler:mainfrom
bakon11:fix/audit-abandon-stale-active

Conversation

@bakon11

@bakon11 bakon11 commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Why

agent-record / test_audit_live_rows.py::test_shipped_record_has_no_abandoned_active_row fails on clean main. That reds every PR (including #163 and #154).

Supersedes closed #173 (head tracking stuck on an older SHA).

What

  • Demote abandoned ACTIVESPIKE where audit reports no branch and no main commit mentioning the row ID
  • Fix engine-matrix.md lifecycle Total SPIKE/ACTIVE counts
  • Align model-matrix architecture checklist rollup + emojis (✅/🚧 → 📋 for demoted SPIKE rows)
  • Minimal STATUS/FEATURES/BENCHMARKS note

Verify (local green)

python3 scripts/audit-live-rows.py --check
python3 tests/scripts/test_audit_live_rows.py
python3 scripts/check-agent-record.py
python3 scripts/check-model-checklist.py
python3 scripts/check-doc-checkpoint.py --base origin/main --head HEAD

Unblocks merge CI for the rest of the queue.

FOLLOWING_AGENTS_PROTOCOL

Following-Agents-Protocol: true
AI-Assisted: true
Assisted-by: Hermes:grok-4.5 [Hermes]

@bakon11
bakon11 force-pushed the fix/audit-abandon-stale-active branch 3 times, most recently from c0c0120 to 9bc6fc4 Compare August 8, 2026 23:45
Live-row audit: ACTIVE rows with no Git evidence → SPIKE so agent-record
passes. Re-pin RUNNABLE_BASELINE + unit test. Document leftover Gemma4/ROCm
lab env knobs and server prompt/max_tokens caps. Roll non-canonical
BENCHMARKS H2 into benchmark-record; keep STATUS under ratchet.

FOLLOWING_AGENTS_PROTOCOL

Following-Agents-Protocol: true
AI-Assisted: true
Assisted-by: Hermes:grok-4.5 [Hermes]
@bakon11
bakon11 force-pushed the fix/audit-abandon-stale-active branch from 9bc6fc4 to 9caccbc Compare August 9, 2026 01:49
@localai-bot

Copy link
Copy Markdown
Collaborator

Thanks for this — it was a real red gate and the diagnosis was right at the time. Closing it as superseded, with the evidence, because the situation changed underneath it.

The premise no longer holds. #177 exists because agent-record / test_shipped_record_has_no_abandoned_active_row failed on clean main. On current main (0cf3dbbb) all three checks the PR names are green:

python3 scripts/audit-live-rows.py --check      -> exit 0, "203 live rows; 0 abandoned ACTIVE"
python3 tests/scripts/test_audit_live_rows.py   -> exit 0
python3 scripts/check-agent-record.py           -> exit 0
python3 scripts/check-model-checklist.py        -> exit 0

d45c8cda ("docs(reconcile): fix behind/stale drift across records to match code state") reconciled the records independently.

And merging it now would be actively wrong, not merely redundant. Three of the rows this PR demotes ACTIVE -> SPIKE are currently ACTIVE with landed code, and the audit's own verdict column says LANDED for each:

Row Landed on main as
SERVE-POOLING-ENDPOINTS 2a6bd64c feat(pooling): pooling task class W0 spike + W1 CPU pooler OP
BACKEND-CUDA-ARCH-ADDITIVITY 8a379182 feat(cuda-arch): cross-family BUILD-SUPPORTED fan-out (W10)
BACKEND-METAL-MLX c351dff2 feat(model): Qwen3-dense on Metal — SACRED gate 16/16

The check-gate-commands.py edit follows from those demotions, so it would drop three rows out of RUNNABLE_BASELINE that legitimately belong there.

Nothing here is a criticism of the change — the rows genuinely looked abandoned when you audited them, and the branch-and-main-commit heuristic is the right one. It is just that the underlying drift got fixed from the other direction first.

If you want to keep the thread going, the durable version of this problem is still open: audit-live-rows.py credits LANDED to any commit whose message names the row ID, with no code-touch discriminator, so its discriminating power decays with every records-only commit. A filter on whether the commit touched src//include//tests//cmake//scripts/ would make the audit mean what it says. That would be a very welcome PR.

@localai-bot localai-bot closed this Aug 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants