record(MODEL-NEMOTRON-H): the spec described a resolver that #569 replaced (#517, #569) - #582
Merged
Merged
Conversation
…laced (#517, #569) FOLLOWING_AGENTS_PROTOCOL A fresh review of #569 found this spec asserting something the tree no longer does. The W1 LOW-3(b) section said Nemotron35LightningSnapshot() "gates the CHECKPOINT_ROOT path on that manifest", and its evidence row B -- add 29f2d174....json, nothing else changed, EXIT=0 -- does not reproduce any more. Adding the manifest now changes nothing; the per-file download sidecars decide. Records cannot disagree with the tree, and this one is worse than merely stale: it documents a proof-by-construction whose construction is void, so a reader would take it as evidence the pin works the way it says. The section is marked SUPERSEDED with the reason -- the manifest records "this revision was downloaded here once", not "these bytes are that revision", and huggingface_hub's _tree_cache.py never invalidates, so manifests ACCUMULATE and an old revision's manifest vouches for new bytes. Row B is retained rather than deleted, labelled as no longer true, because what was tried and why it was insufficient is the part a future porter needs. Also links the two gate-infrastructure issues this row depends on, closing the review's second finding: the protocol wants an issue linked from the roadmap table, the row's spec and the PR, and #569 was in only one of the three. The roadmap table half landed in ce70711. Carried into the spec because it is an operating condition and not a defect: W6 must run with VT_NEMOTRON35_SNAPSHOT UNSET and must record the resolved directory, since that override is deliberately never revision-checked and would silently accept a substituted checkpoint -- which is exactly what a token gate cannot see. Records only, no product code touched. Following-Agents-Protocol: true AI-Assisted: true Assisted-by: AGENT:claude-opus-5 [Claude Code]
localai-bot
pushed a commit
that referenced
this pull request
Aug 13, 2026
…ver correction (#517) Fifth re-merge; `origin/main` `751325460` -> `65625f34a` (#582), a records-only commit that rewrites §2 of the SAME keyed record this branch also edits in §2. Source and tests are untouched by it, so no gate is invalidated. `.agents/specs/nemotron-h-model.md` was merged BY HAND again per AGENTS.md: `git checkout origin/main -- <spec>` first, discarding git's automatic resolution, then the three W2 regions re-applied with uniqueness-asserted anchors. Verified block by block (md5 per `##` heading) -- **16 blocks, 13 BYTE-IDENTICAL to main, 3 differ and all three are W2's own**: §2's single table row (`apply_routed_scale_to_output=True` at `nemotron_h.py:234`, factor `:233`), the new §6a, and §7 `Now`. Main's rewritten §2 PROSE is carried whole -- the W2 edit is one row of the anchor table above it and does not touch the resolver narrative #582 corrected. Delta vs `origin/main` remains exactly this branch's eight W2 files. FOLLOWING_AGENTS_PROTOCOL Refs #517. Refs #582. Following-Agents-Protocol: true AI-Assisted: true Assisted-by: AGENT:claude-opus-5 [Claude Code]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A fresh review of #569 found
.agents/specs/nemotron-h-model.mdasserting something the tree no longer does: the W1 LOW-3(b) section claimed the resolver "gates theCHECKPOINT_ROOTpath on that manifest", and its evidence row B (add29f2d174….json, nothing else changed → EXIT=0) no longer reproduces.Worse than stale — it documents a proof by construction whose construction is void, so a reader would take it as evidence the pin works as described.
_tree_cache.pynever invalidates)ce7071122VT_NEMOTRON35_SNAPSHOTunset, record the resolved directoryRecords only.
agent-preflight.sh --stagedgreen.🤖 Generated with Claude Code