-
-
Notifications
You must be signed in to change notification settings - Fork 32.6k
[docs] Add Breadcrumbs TypeScript demos #15139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
No bundle size changes comparing 240dc18...63eb35b |
I have done |
Have you run |
@Dudrie yes, I get this error ~/project/material-ui(next) » yarn docs:typescript:check xuzihao@MacBook-Pro
yarn run v1.1.0
warning You are using Node "10.14.2" which is not supported and may encounter bugs or unexpected behavior. Yarn supports the following semver range: "^4.8.0 || ^5.7.0 || ^6.2.2 || ^8.0.0"
$ tslint -p docs/tsconfig.json
ERROR: /Users/xuzihao/project/material-ui/docs/src/pages/demos/snackbars/IntegrationNotistack.tsx:4:55 - TypeScript@next compile error:
Module '"../../../../../../../../../Users/xuzihao/project/material-ui/node_modules/notistack"' has no exported member 'withSnackbarProps'.
error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command. But this is not a file I wrote. Then I sorted the import order in the ts file the same as js. But still haven't tested_build - Are the compiled TypeScript demos equivalent to the JavaScript demos? |
One thing I noticed is that you did two things in one PR:
As @oliviertassinari mentioned in his Hook demos issue, we should do one PR for the demo (so the tests check if the demos are equivalent) and one extra PR for the conversion into a hook. The question is (and I would wait for an answer, before doing any further action): Can this PR be an exception to that statement or should you "undo" the conversion to hooks? 🤔 Maybe this prevents you from trying things the whole afternoon on why the test_build fails 🙈. |
@Dudrie Thanks, I will continue to try |
Try running just However, according to the output of the test_unit test, the test itself does not fail because of that error (in fact it does not even raise that one) 🙈 |
Thank you for your help, I solved the above problem independently.. 🤗 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are 2 casts here that are not ideal. We can follow up with an improvement in a future PR though.
@Adherentman Much appreciated, thanks. |
Add TypeScript demos for each of the existing breadcrumbs demos
This is my first PR here 😄, let me know if there's anything I missed 🤙 .