[Button] Improve types with regard to react-router #15193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
added
new feature
eps1lon
commented
Apr 4, 2019
| ); | ||
|
|
||
| const MyLink = React.forwardRef<HTMLAnchorElement, LinkProps>((props, ref) => { | ||
| return <ReactRouterLink innerRef={ref as any} {...props} />; |
There was a problem hiding this comment.
Fixed with DefinitelyTyped/DefinitelyTyped#34464
|
No bundle size changes comparing cc0ac06...ebb908c |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15171
It already accepted
forwardRefcomponents (just added a test with working usage). Used the opportunity to improve types for custom wrapper components forButton.