Skip to content

[MenuItem][ListItemButton] Add 'component' to Typescript declarations #33710 #33808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

[MenuItem][ListItemButton] Add 'component' to Typescript declarations #33710 #33808

wants to merge 4 commits into from

Conversation

Dsalazar1685
Copy link
Contributor

Closes #33710

@mui-bot
Copy link

mui-bot commented Aug 5, 2022 •
edited
Loading

No bundle size changes

Generated by 🚫 dangerJS against 9a0d6de

siriwatknp
siriwatknp requested changes Sep 7, 2022
View reviewed changes
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. Could you also create *.spec.tsx to check if the component prop works as expected?
You can take a look at Button.spec.tsx as a guideline.

@michaldudak michaldudak added the component: menu This is the name of the generic UI component, not the React module! label Oct 12, 2022
@mnajdova
Copy link
Member

@siriwatknp should we close this based on #33799?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriwatknp siriwatknp siriwatknp requested changes

@hbjORbj hbjORbj Awaiting requested review from hbjORbj

@mnajdova mnajdova Awaiting requested review from mnajdova

Assignees
No one assigned
Labels
component: menu This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typescript: MenuItem missing "component" prop
6 participants
@Dsalazar1685 @mui-bot @mnajdova @siriwatknp @michaldudak @ZeeshanTamboli